Cirrus CI for msys2 are working now, but still buiding failed

qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed

* Cirrus CI for msys2 are working now, but still buiding failed
@ 2020-09-01 20:47 罗勇刚(Yonggang Luo)
  2020-09-02 10:38 ` Thomas Huth
  0 siblings, 1 reply; 6+ messages in thread
From: 罗勇刚(Yonggang Luo) @ 2020-09-01 20:47 UTC (permalink / raw)
  To: qemu-level

[-- Attachment #1: Type: text/plain, Size: 2852 bytes --]

https://cirrus-ci.com/task/6375504892657664

failed with:
```

Compiling C object
libqemu-s390x-softmmu.fa.p/meson-generated_.._trace_generated-helpers.c.obj
Compiling C object
libqemu-s390x-softmmu.fa.p/meson-generated_.._qapi_qapi-events.c.obj
Compiling C object
libqemu-s390x-softmmu.fa.p/meson-generated_.._qapi_qapi-emit-events.c.obj
Linking static target libblock.fa
Linking target qemu-system-aarch64.exe
Linking target qemu-system-aarch64w.exe
Linking target qemu-system-alpha.exe
Linking target qemu-system-alphaw.exe
Linking target qemu-system-arm.exe
Linking target qemu-system-armw.exe
Linking target qemu-system-avr.exe
Linking target qemu-system-avrw.exe
C:/tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
cannot find -lfdt
C:/tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
cannot find -lfdt
C:/tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
cannot find -lfdt
C:/tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
cannot find -lfdt
collect2.exe: error: ld returned 1 exit status
collect2.exe: error: ld returned 1 exit status
collect2.exe: error: ld returned 1 exit status
collect2.exe: error: ld returned 1 exit status
make: *** [Makefile.ninja:2258: qemu-system-avr.exe] Error 1
make: *** Waiting for unfinished jobs....
make: *** [Makefile.ninja:1970: qemu-system-alpha.exe] Error 1
make: *** [Makefile.ninja:2260: qemu-system-avrw.exe] Error 1
make: *** [Makefile.ninja:1972: qemu-system-alphaw.exe] Error 1
C:/tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
cannot find -lfdt
C:/tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
cannot find -lfdt
C:/tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
cannot find -lfdt
C:/tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe:
cannot find -lfdt
collect2.exe: error: ld returned 1 exit status
collect2.exe: error: ld returned 1 exit status
make: *** [Makefile.ninja:2184: qemu-system-armw.exe] Error 1
make: *** [Makefile.ninja:2182: qemu-system-arm.exe] Error 1
collect2.exe: error: ld returned 1 exit status
make: *** [Makefile.ninja:1875: qemu-system-aarch64.exe] Error 1
collect2.exe: error: ld returned 1 exit status
make: *** [Makefile.ninja:1877: qemu-system-aarch64w.exe] Error 1

C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build>if
2 NEQ 0 exit /b 2

Exit status: 2

```

-- 
         此致
礼
罗勇刚
Yours
    sincerely,
Yonggang Luo

[-- Attachment #2: Type: text/html, Size: 3192 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Cirrus CI for msys2 are working now, but still buiding failed
  2020-09-01 20:47 Cirrus CI for msys2 are working now, but still buiding failed 罗勇刚(Yonggang Luo)
@ 2020-09-02 10:38 ` Thomas Huth
  2020-09-02 11:27   ` Paolo Bonzini
  2020-09-02 11:41   ` Paolo Bonzini
  0 siblings, 2 replies; 6+ messages in thread
From: Thomas Huth @ 2020-09-02 10:38 UTC (permalink / raw)
  To: luoyonggang, qemu-level
  Cc: Daniel P. Berrange, qemu-arm, qemu-ppc@nongnu.org,
	Marc-André Lureau, Paolo Bonzini, David Gibson

On 01/09/2020 22.47, 罗勇刚(Yonggang Luo) wrote:
> https://cirrus-ci.com/task/6375504892657664
> 
> 
> failed with:
> ```
> 
> Compiling C object libqemu-s390x-softmmu.fa.p/meson-generated_.._trace_generated-helpers.c.obj
> Compiling C object libqemu-s390x-softmmu.fa.p/meson-generated_.._qapi_qapi-events.c.obj
> Compiling C object libqemu-s390x-softmmu.fa.p/meson-generated_.._qapi_qapi-emit-events.c.obj
> Linking static target libblock.fa
> Linking target qemu-system-aarch64.exe
> Linking target qemu-system-aarch64w.exe
> Linking target qemu-system-alpha.exe
> Linking target qemu-system-alphaw.exe
> Linking target qemu-system-arm.exe
> Linking target qemu-system-armw.exe
> Linking target qemu-system-avr.exe
> Linking target qemu-system-avrw.exe
> C:/tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: cannot find -lfdt
> C:/tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: cannot find -lfdt
> C:/tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: cannot find -lfdt
> C:/tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: cannot find -lfdt
> collect2.exe: error: ld returned 1 exit status
> collect2.exe: error: ld returned 1 exit status
> collect2.exe: error: ld returned 1 exit status
> collect2.exe: error: ld returned 1 exit status
> make: *** [Makefile.ninja:2258: qemu-system-avr.exe] Error 1
> make: *** Waiting for unfinished jobs....
> make: *** [Makefile.ninja:1970: qemu-system-alpha.exe] Error 1
> make: *** [Makefile.ninja:2260: qemu-system-avrw.exe] Error 1
> make: *** [Makefile.ninja:1972: qemu-system-alphaw.exe] Error 1
> C:/tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: cannot find -lfdt
> C:/tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: cannot find -lfdt
> C:/tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: cannot find -lfdt
> C:/tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: cannot find -lfdt
> collect2.exe: error: ld returned 1 exit status
> collect2.exe: error: ld returned 1 exit status
> make: *** [Makefile.ninja:2184: qemu-system-armw.exe] Error 1
> make: *** [Makefile.ninja:2182: qemu-system-arm.exe] Error 1
> collect2.exe: error: ld returned 1 exit status
> make: *** [Makefile.ninja:1875: qemu-system-aarch64.exe] Error 1
> collect2.exe: error: ld returned 1 exit status
> make: *** [Makefile.ninja:1877: qemu-system-aarch64w.exe] Error 1

Wow, that looks quite promising already! But I wonder why the build
system is trying to link libfdt to targets like qemu-system-avr that do
not need it?
And for the targets that need fdt, it should use the dtc submodule... I
can see in the log that the dtc submodule is checked out, but it does
not seem to be compiled ? As a test, could you please try to run
"configure" with "--disable-fdt" there?

 Thomas



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Cirrus CI for msys2 are working now, but still buiding failed
  2020-09-02 10:38 ` Thomas Huth
@ 2020-09-02 11:27   ` Paolo Bonzini
  2020-09-02 11:41   ` Paolo Bonzini
  1 sibling, 0 replies; 6+ messages in thread
From: Paolo Bonzini @ 2020-09-02 11:27 UTC (permalink / raw)
  To: Thomas Huth, luoyonggang, qemu-level
  Cc: Marc-André Lureau, qemu-arm, qemu-ppc@nongnu.org,
	Daniel P. Berrange, David Gibson

On 02/09/20 12:38, Thomas Huth wrote:
>> C:/tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: cannot find -lfdt
>> C:/tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: cannot find -lfdt
>> C:/tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: cannot find -lfdt
>> C:/tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: cannot find -lfdt
>> collect2.exe: error: ld returned 1 exit status
>> collect2.exe: error: ld returned 1 exit status
>> make: *** [Makefile.ninja:2184: qemu-system-armw.exe] Error 1
>> make: *** [Makefile.ninja:2182: qemu-system-arm.exe] Error 1
>> collect2.exe: error: ld returned 1 exit status
>> make: *** [Makefile.ninja:1875: qemu-system-aarch64.exe] Error 1
>> collect2.exe: error: ld returned 1 exit status
>> make: *** [Makefile.ninja:1877: qemu-system-aarch64w.exe] Error 1
> Wow, that looks quite promising already! But I wonder why the build
> system is trying to link libfdt to targets like qemu-system-avr that do
> not need it?
> And for the targets that need fdt, it should use the dtc submodule... I
> can see in the log that the dtc submodule is checked out, but it does
> not seem to be compiled ? As a test, could you please try to run
> "configure" with "--disable-fdt" there?

This is preexisting, lots of libraries are wedded blindly to QEMU_CFLAGS
and LIBS.  It can be fixed once tests are converted to Meson.

Paolo



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Cirrus CI for msys2 are working now, but still buiding failed
  2020-09-02 10:38 ` Thomas Huth
  2020-09-02 11:27   ` Paolo Bonzini
@ 2020-09-02 11:41   ` Paolo Bonzini
  2020-09-02 15:06     ` 罗勇刚(Yonggang Luo)
  1 sibling, 1 reply; 6+ messages in thread
From: Paolo Bonzini @ 2020-09-02 11:41 UTC (permalink / raw)
  To: Thomas Huth, luoyonggang, qemu-level
  Cc: Marc-André Lureau, qemu-arm, qemu-ppc@nongnu.org,
	Daniel P. Berrange, David Gibson

On 02/09/20 12:38, Thomas Huth wrote:
> Wow, that looks quite promising already! But I wonder why the build
> system is trying to link libfdt to targets like qemu-system-avr that do
> not need it?
> And for the targets that need fdt, it should use the dtc submodule... I
> can see in the log that the dtc submodule is checked out, but it does
> not seem to be compiled ? As a test, could you please try to run
> "configure" with "--disable-fdt" there?

Mark and Yonggang have reported an issue where the linker gets
an msys path like -L/e/qemu/dtc but it wants -LE:/qemu/dtc instead.
But fortunately we can just use -Ldtc instead, which would be a patch like

diff --git a/configure b/configure
index 56ceca2f68..34e81a7b60 100755
--- a/configure
+++ b/configure
@@ -943,7 +943,7 @@ Linux)
   linux="yes"
   linux_user="yes"
   kvm="yes"
-  QEMU_INCLUDES="-isystem ${source_path}/linux-headers -I$PWD/linux-headers $QEMU_INCLUDES"
+  QEMU_INCLUDES="-isystem ${source_path}/linux-headers -Ilinux-headers $QEMU_INCLUDES"
   libudev="yes"
 ;;
 esac
@@ -4259,7 +4259,7 @@ EOF
               symlink "$source_path/dtc/Makefile" "dtc/Makefile"
           fi
           fdt_cflags="-I${source_path}/dtc/libfdt"
-          fdt_ldflags="-L$PWD/dtc/libfdt"
+          fdt_ldflags="-Ldtc/libfdt"
           fdt_libs="$fdt_libs"
       elif test "$fdt" = "yes" ; then
           # Not a git build & no libfdt found, prompt for system install
@@ -5244,7 +5244,7 @@ case "$capstone" in
     else
       LIBCAPSTONE=libcapstone.a
     fi
-    capstone_libs="-L$PWD/capstone -lcapstone"
+    capstone_libs="-Lcapstone -lcapstone"
     capstone_cflags="-I${source_path}/capstone/include"
     ;;
 
@@ -6244,8 +6244,8 @@ case "$slirp" in
       git_submodules="${git_submodules} slirp"
     fi
     mkdir -p slirp
-    slirp_cflags="-I${source_path}/slirp/src -I$PWD/slirp/src"
-    slirp_libs="-L$PWD/slirp -lslirp"
+    slirp_cflags="-I${source_path}/slirp/src -Islirp/src"
+    slirp_libs="-Lslirp -lslirp"
     if test "$mingw32" = "yes" ; then
       slirp_libs="$slirp_libs -lws2_32 -liphlpapi"
     fi

Paolo



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: Cirrus CI for msys2 are working now, but still buiding failed
  2020-09-02 11:41   ` Paolo Bonzini
@ 2020-09-02 15:06     ` 罗勇刚(Yonggang Luo)
  2020-09-02 15:43       ` Paolo Bonzini
  0 siblings, 1 reply; 6+ messages in thread
From: 罗勇刚(Yonggang Luo) @ 2020-09-02 15:06 UTC (permalink / raw)
  To: Paolo Bonzini
  Cc: Thomas Huth, Daniel P. Berrange, qemu-level, qemu-arm,
	qemu-ppc@nongnu.org, Marc-André Lureau, David Gibson

[-- Attachment #1: Type: text/plain, Size: 2593 bytes --]

I've already making CI green match the cross version, and the fix is not
just about -L, but also need to move the git submodule update to the end of
the file

On Wed, Sep 2, 2020 at 7:41 PM Paolo Bonzini <pbonzini@redhat.com> wrote:

> On 02/09/20 12:38, Thomas Huth wrote:
> > Wow, that looks quite promising already! But I wonder why the build
> > system is trying to link libfdt to targets like qemu-system-avr that do
> > not need it?
> > And for the targets that need fdt, it should use the dtc submodule... I
> > can see in the log that the dtc submodule is checked out, but it does
> > not seem to be compiled ? As a test, could you please try to run
> > "configure" with "--disable-fdt" there?
>
> Mark and Yonggang have reported an issue where the linker gets
> an msys path like -L/e/qemu/dtc but it wants -LE:/qemu/dtc instead.
> But fortunately we can just use -Ldtc instead, which would be a patch like
>
> diff --git a/configure b/configure
> index 56ceca2f68..34e81a7b60 100755
> --- a/configure
> +++ b/configure
> @@ -943,7 +943,7 @@ Linux)
>    linux="yes"
>    linux_user="yes"
>    kvm="yes"
> -  QEMU_INCLUDES="-isystem ${source_path}/linux-headers
> -I$PWD/linux-headers $QEMU_INCLUDES"
> +  QEMU_INCLUDES="-isystem ${source_path}/linux-headers -Ilinux-headers
> $QEMU_INCLUDES"
>    libudev="yes"
>  ;;
>  esac
> @@ -4259,7 +4259,7 @@ EOF
>                symlink "$source_path/dtc/Makefile" "dtc/Makefile"
>            fi
>            fdt_cflags="-I${source_path}/dtc/libfdt"
> -          fdt_ldflags="-L$PWD/dtc/libfdt"
> +          fdt_ldflags="-Ldtc/libfdt"
>            fdt_libs="$fdt_libs"
>        elif test "$fdt" = "yes" ; then
>            # Not a git build & no libfdt found, prompt for system install
> @@ -5244,7 +5244,7 @@ case "$capstone" in
>      else
>        LIBCAPSTONE=libcapstone.a
>      fi
> -    capstone_libs="-L$PWD/capstone -lcapstone"
> +    capstone_libs="-Lcapstone -lcapstone"
>      capstone_cflags="-I${source_path}/capstone/include"
>      ;;
>
> @@ -6244,8 +6244,8 @@ case "$slirp" in
>        git_submodules="${git_submodules} slirp"
>      fi
>      mkdir -p slirp
> -    slirp_cflags="-I${source_path}/slirp/src -I$PWD/slirp/src"
> -    slirp_libs="-L$PWD/slirp -lslirp"
> +    slirp_cflags="-I${source_path}/slirp/src -Islirp/src"
> +    slirp_libs="-Lslirp -lslirp"
>      if test "$mingw32" = "yes" ; then
>        slirp_libs="$slirp_libs -lws2_32 -liphlpapi"
>      fi
>
> Paolo
>
>

-- 
         此致
礼
罗勇刚
Yours
    sincerely,
Yonggang Luo

[-- Attachment #2: Type: text/html, Size: 3498 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Cirrus CI for msys2 are working now, but still buiding failed
  2020-09-02 15:06     ` 罗勇刚(Yonggang Luo)
@ 2020-09-02 15:43       ` Paolo Bonzini
  0 siblings, 0 replies; 6+ messages in thread
From: Paolo Bonzini @ 2020-09-02 15:43 UTC (permalink / raw)
  To: luoyonggang
  Cc: Thomas Huth, Daniel P. Berrange, qemu-level, qemu-arm,
	qemu-ppc@nongnu.org, Marc-André Lureau, David Gibson

On 02/09/20 17:06, 罗勇刚(Yonggang Luo) wrote:
> I've already making CI green match the cross version, and the fix is not
> just about -L, but also need to move the git submodule update to the end
> of the file

Ok, please send the separate patch for the git submodule update.

Paolo



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-09-02 15:44 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-01 20:47 Cirrus CI for msys2 are working now, but still buiding failed 罗勇刚(Yonggang Luo)
2020-09-02 10:38 ` Thomas Huth
2020-09-02 11:27   ` Paolo Bonzini
2020-09-02 11:41   ` Paolo Bonzini
2020-09-02 15:06     ` 罗勇刚(Yonggang Luo)
2020-09-02 15:43       ` Paolo Bonzini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).