From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60228) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bw5Gz-0003UV-J3 for qemu-devel@nongnu.org; Mon, 17 Oct 2016 06:36:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bw5Gy-0007fU-Rt for qemu-devel@nongnu.org; Mon, 17 Oct 2016 06:36:01 -0400 References: <1476700224-13186-1-git-send-email-lvivier@redhat.com> <1476700224-13186-2-git-send-email-lvivier@redhat.com> From: Thomas Huth Message-ID: Date: Mon, 17 Oct 2016 12:35:56 +0200 MIME-Version: 1.0 In-Reply-To: <1476700224-13186-2-git-send-email-lvivier@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 1/6] tests: fix memory leak in virtio-scsi-test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier , qemu-devel@nongnu.org Cc: dgibson@redhat.com, qemu-ppc@nongnu.org, Greg Kurz On 17.10.2016 12:30, Laurent Vivier wrote: > vs is allocated in qvirtio_scsi_pci_init() and never freed. > > Signed-off-by: Laurent Vivier > Reviewed-by: Greg Kurz > --- > tests/virtio-scsi-test.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/virtio-scsi-test.c b/tests/virtio-scsi-test.c > index 79088bb..94d75b1 100644 > --- a/tests/virtio-scsi-test.c > +++ b/tests/virtio-scsi-test.c > @@ -64,6 +64,7 @@ static void qvirtio_scsi_pci_free(QVirtIOSCSI *vs) > qvirtio_pci_device_disable(container_of(vs->dev, QVirtioPCIDevice, vdev)); > g_free(vs->dev); > qpci_free_pc(vs->bus); > + g_free(vs); > } > > static uint64_t qvirtio_scsi_alloc(QVirtIOSCSI *vs, size_t alloc_size, > Reviewed-by: Thomas Huth