From: Thomas Huth <thuth@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, Jan Kiszka <jan.kiszka@siemens.com>,
Jason Wang <jasowang@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Samuel Thibault <samuel.thibault@ens-lyon.org>,
brad@comstyle.com
Subject: Re: [Qemu-devel] [PATCH v2] slirp: Implement RFC2132 TFTP server name
Date: Mon, 27 Aug 2018 08:51:04 +0200 [thread overview]
Message-ID: <bbffc053-985e-3e27-dddf-1146891e0acb@redhat.com> (raw)
In-Reply-To: <20180827022253.28140-1-famz@redhat.com>
On 2018-08-27 04:22, Fam Zheng wrote:
> This new usernet option can be used to add data for option 66 (tftp
> server name) in the BOOTP reply, which is useful in PXE based automatic
> OS install such as OpenBSD.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>
> v2: - Adjust parameter order and field placement to be closer to other
> tftp options. [Samuel]
> - Drop 'optional'. [Eric]
> ---
> net/slirp.c | 5 ++++-
> qapi/net.json | 5 ++++-
> slirp/bootp.c | 8 ++++++++
> slirp/bootp.h | 1 +
> slirp/libslirp.h | 4 +++-
> slirp/slirp.c | 5 ++++-
> slirp/slirp.h | 1 +
> 7 files changed, 25 insertions(+), 4 deletions(-)
Please add information about this new parameter to the documentation in
qemu-options.hx, too!
Thomas
next prev parent reply other threads:[~2018-08-27 6:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 2:22 [Qemu-devel] [PATCH v2] slirp: Implement RFC2132 TFTP server name Fam Zheng
2018-08-27 6:51 ` Thomas Huth [this message]
2018-08-27 7:03 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbffc053-985e-3e27-dddf-1146891e0acb@redhat.com \
--to=thuth@redhat.com \
--cc=armbru@redhat.com \
--cc=brad@comstyle.com \
--cc=famz@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=jasowang@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).