From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>, qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Stefano Garzarella" <sgarzare@redhat.com>,
"Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>
Subject: Re: [PATCH] vhost-user-snd: Use virtio_get_config_size()
Date: Thu, 13 Feb 2025 16:07:47 +0100 [thread overview]
Message-ID: <bc05ff1c-94ce-4877-9b8f-9fb909cd67a3@linaro.org> (raw)
In-Reply-To: <20250213132513.767709-1-mvaralar@redhat.com>
On 13/2/25 14:25, Matias Ezequiel Vara Larsen wrote:
> Use virtio_get_config_size() rather than sizeof(struct
> virtio_snd_config) for the config_size in the vhost-user-snd frontend.
> The frontend shall rely on device features for the size of the device
> configuration space. This fixes an issue introduced by commit ab0c7fb2
> in which the optional field `control` is added to the virtio_snd_config
> structure. This breaks vhost-user-device backends that do not implement
> the `controls` field.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2805
> Suggested-by: Stefano Garzarella <sgarzare@redhat.com>
> Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> ---
> hw/virtio/vhost-user-snd.c | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
¡¡Bien ahí!!
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2025-02-13 15:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 13:25 [PATCH] vhost-user-snd: Use virtio_get_config_size() Matias Ezequiel Vara Larsen
2025-02-13 15:07 ` Philippe Mathieu-Daudé [this message]
2025-02-14 16:52 ` Matias Ezequiel Vara Larsen
2025-02-13 15:31 ` Stefano Garzarella
2025-02-13 15:43 ` Stefano Garzarella
2025-02-13 16:22 ` Stefano Garzarella
2025-02-14 16:56 ` Matias Ezequiel Vara Larsen
2025-02-14 16:59 ` Matias Ezequiel Vara Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc05ff1c-94ce-4877-9b8f-9fb909cd67a3@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=manos.pitsidianakis@linaro.org \
--cc=mst@redhat.com \
--cc=mvaralar@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).