From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: yoshinori.sato@nifty.com, Thomas Huth <thuth@redhat.com>
Subject: Re: [PATCH] rx: cpu: fix interrupts check in rx_cpu_do_interrupt()
Date: Fri, 31 Oct 2025 21:28:41 +0100 [thread overview]
Message-ID: <bc0b52b9-19df-43b9-8f20-61f7101b7975@linaro.org> (raw)
In-Reply-To: <20251030165932.138512-1-imammedo@redhat.com>
On 30/10/25 17:59, Igor Mammedov wrote:
> Commit [1] broke interrupt handling, replacing interrupts fetch with a bool
> and then the remaining code attempting to check individual bits
> on that bool value, which effectively masked those interrupts.
>
> Fix it by checking individual interrupt bits directly instead of
> old 'fetch then check' approach.
>
> 1)
> Fixes: 87511341c30d ("add cpu_test_interrupt()/cpu_set_interrupt() helpers and use them tree wide")
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> target/rx/helper.c | 41 ++++++++++++++++++-----------------------
> 1 file changed, 18 insertions(+), 23 deletions(-)
Queued, thanks.
prev parent reply other threads:[~2025-10-31 20:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 16:59 [PATCH] rx: cpu: fix interrupts check in rx_cpu_do_interrupt() Igor Mammedov
2025-10-31 7:34 ` Thomas Huth
2025-10-31 8:12 ` Philippe Mathieu-Daudé
2025-10-31 20:28 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc0b52b9-19df-43b9-8f20-61f7101b7975@linaro.org \
--to=philmd@linaro.org \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=yoshinori.sato@nifty.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).