qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	qemu-block@nongnu.org, Markus Armbruster <armbru@redhat.com>,
	Max Reitz <mreitz@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	John Snow <jsnow@redhat.com>
Subject: Re: [PATCH 1/5] hxtool: Support SRST/ERST directives
Date: Tue, 21 Jan 2020 10:33:19 -1000	[thread overview]
Message-ID: <bc15214d-664b-b6e8-87b4-80b1de4be821@linaro.org> (raw)
In-Reply-To: <20200121191033.28195-2-peter.maydell@linaro.org>

On 1/21/20 9:10 AM, Peter Maydell wrote:
> We want to add support for including rST document fragments
> in our .hx files, in the same way we currently have texinfo
> fragments. These will be delimited by SRST and ERST directives,
> in the same way the texinfo is delimited by STEXI/ETEXI.
> The rST fragments will not be extracted by the hxtool
> script, but by a different mechanism, so all we need to
> do in hxtool is have it ignore all the text inside a
> SRST/ERST section, with suitable error-checking for
> mismatched rST-vs-texi fragment delimiters.
> 
> The resulting effective state machine has only three states:
>  * flag = 0, rstflag = 0 : reading section for C output
>  * flag = 1, rstflag = 0 : reading texi fragment
>  * flag = 0, rstflag = 1 : reading rST fragment
> and flag = 1, rstflag = 1 is not possible. Using two
> variables makes the parallel between the rST handling and
> the texi handling clearer; in any case all this code will
> be deleted once we've converted entirely to rST.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  scripts/hxtool | 33 ++++++++++++++++++++++++++++++++-
>  1 file changed, 32 insertions(+), 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~


  reply	other threads:[~2020-01-21 20:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-21 19:10 [PATCH 0/5] qemu-img: convert to rST Peter Maydell
2020-01-21 19:10 ` [PATCH 1/5] hxtool: Support SRST/ERST directives Peter Maydell
2020-01-21 20:33   ` Richard Henderson [this message]
2020-01-21 19:10 ` [PATCH 2/5] docs/sphinx: Add new hxtool Sphinx extension Peter Maydell
2020-01-21 21:53   ` Richard Henderson
2020-01-21 22:22     ` Peter Maydell
2020-01-22  0:15       ` Richard Henderson
2020-01-23 17:33       ` Peter Maydell
2020-01-21 19:10 ` [PATCH 3/5] qemu-img-cmds.hx: Add rST documentation fragments Peter Maydell
2020-01-21 21:55   ` Richard Henderson
2020-01-21 19:10 ` [PATCH 4/5] qemu-img: Convert invocation documentation to rST Peter Maydell
2020-01-21 19:10 ` [PATCH 5/5] qemu-img-cmds.hx: Remove texinfo document fragments Peter Maydell
2020-01-21 21:55   ` Richard Henderson
2020-01-21 20:16 ` [PATCH 0/5] qemu-img: convert to rST no-reply
2020-01-21 20:55 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc15214d-664b-b6e8-87b4-80b1de4be821@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=armbru@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).