From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>
Cc: "patches@linaro.org" <patches@linaro.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] configure: symlink directories, not wildcarded files
Date: Tue, 30 Oct 2018 16:02:59 +0100 [thread overview]
Message-ID: <bc287aaf-61e2-3ed5-0f53-daf505b46047@redhat.com> (raw)
In-Reply-To: <CAFEAcA91k6jx=XY5VbnA1JFWh+0Qv0T-zA9kcdid-jRtnh=s1A@mail.gmail.com>
On 30/10/18 14:08, Peter Maydell wrote:
> On 30 October 2018 at 13:01, Peter Maydell <peter.maydell@linaro.org> wrote:
>> ...having sent this out and moved on to something else, I have
>> discovered a problem with it. If you configure a build tree
>> using this, and then switch back to a git branch which has
>> the older configure, then that configure will end up trashing
>> all the tests/acpi-test-data and tests/hex-loader-check-data
>> files in the source tree by replacing them with symlinks to
>> themselves... This is fixable by doing "git checkout tests"
>> but it's a bit of a landmine for bisection :-(
Got there now switching to another series after testing yours ;)
> Maybe we should standardize on having all data files for tests
> be in tests/data, which is and has always been a symlink to
> a directory. That would avoid this problem with old versions
> of configure mangling the source directory by accident.
This seems the clever move.
>
> thanks
> -- PMM
>
prev parent reply other threads:[~2018-10-30 15:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 12:50 [Qemu-devel] [PATCH 0/3] configure: symlink directories, not wildcarded files Peter Maydell
2018-10-30 12:50 ` [Qemu-devel] [PATCH 1/3] configure: Rename FILES variable to LINKS Peter Maydell
2018-10-30 13:13 ` Philippe Mathieu-Daudé
2018-10-30 12:50 ` [Qemu-devel] [PATCH 2/3] configure: Symlink entire test directories rather than individual files Peter Maydell
2018-10-30 12:50 ` [Qemu-devel] [PATCH 3/3] configure: Use FILES loop for all build tree symlinks Peter Maydell
2018-10-30 13:01 ` [Qemu-devel] [PATCH 0/3] configure: symlink directories, not wildcarded files Peter Maydell
2018-10-30 13:08 ` Peter Maydell
2018-10-30 15:02 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc287aaf-61e2-3ed5-0f53-daf505b46047@redhat.com \
--to=philmd@redhat.com \
--cc=mst@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).