From: Hanna Czenczek <hreitz@redhat.com>
To: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, eblake@redhat.com,
berto@igalia.com, den@virtuozzo.com
Subject: Re: [PATCH 1/7] qcow2: make function update_refcount_discard() global
Date: Tue, 31 Oct 2023 16:27:25 +0100 [thread overview]
Message-ID: <bc28bffe-672f-47bf-9824-2fde09f00768@redhat.com> (raw)
In-Reply-To: <20231020215622.789260-2-andrey.drobyshev@virtuozzo.com>
On 20.10.23 23:56, Andrey Drobyshev wrote:
> We are going to need it for discarding separate subclusters. The
> function itself doesn't do anything with the refcount tables,
I think the idea behind the naming was that updating refcounts can lead
to clusters being discarded, i.e. update_refcount_discard() did the
“discard” part of “update_refcount”.
> it simply
> adds a discard request to the queue, so rename it to qcow2_queue_discard().
But that’s fine, too.
> Signed-off-by: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
> ---
> block/qcow2-refcount.c | 8 ++++----
> block/qcow2.h | 2 ++
> 2 files changed, 6 insertions(+), 4 deletions(-)
Reviewed-by: Hanna Czenczek <hreitz@redhat.com>
next prev parent reply other threads:[~2023-10-31 15:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 21:56 [PATCH 0/7] qcow2: make subclusters discardable Andrey Drobyshev
2023-10-20 21:56 ` [PATCH 1/7] qcow2: make function update_refcount_discard() global Andrey Drobyshev
2023-10-31 15:27 ` Hanna Czenczek [this message]
2023-10-20 21:56 ` [PATCH 2/7] qcow2: add get_sc_range_info() helper for working with subcluster ranges Andrey Drobyshev
2023-10-31 15:53 ` Hanna Czenczek
2023-11-09 12:32 ` Andrey Drobyshev
2023-10-20 21:56 ` [PATCH 3/7] qcow2: zeroize the entire cluster when there're no non-zero subclusters Andrey Drobyshev
2023-10-31 16:06 ` Hanna Czenczek
2023-10-20 21:56 ` [PATCH 4/7] qcow2: make subclusters discardable Andrey Drobyshev
2023-10-27 11:10 ` Jean-Louis Dupond
2024-04-16 19:56 ` Andrey Drobyshev
2024-04-19 9:06 ` Jean-Louis Dupond
2023-10-31 16:32 ` Hanna Czenczek
2023-11-09 15:05 ` Andrey Drobyshev
2023-10-31 16:33 ` Hanna Czenczek
2023-11-10 13:26 ` Andrey Drobyshev
2023-11-03 15:53 ` Hanna Czenczek
2023-10-20 21:56 ` [PATCH 5/7] qcow2: zero_l2_subclusters: fall through to discard operation when requested Andrey Drobyshev
2023-11-03 15:19 ` Hanna Czenczek
2023-11-10 13:17 ` Andrey Drobyshev
2023-10-20 21:56 ` [PATCH 6/7] iotests/common.rc: add disk_usage function Andrey Drobyshev
2023-11-03 15:20 ` Hanna Czenczek
2023-11-09 12:35 ` Andrey Drobyshev
2023-10-20 21:56 ` [PATCH 7/7] iotests/271: check disk usage on subcluster-based discard/unmap Andrey Drobyshev
2023-11-03 15:51 ` Hanna Czenczek
2023-11-03 15:59 ` Hanna Czenczek
2023-11-09 14:05 ` Andrey Drobyshev
2023-11-09 13:55 ` Andrey Drobyshev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc28bffe-672f-47bf-9824-2fde09f00768@redhat.com \
--to=hreitz@redhat.com \
--cc=andrey.drobyshev@virtuozzo.com \
--cc=berto@igalia.com \
--cc=den@virtuozzo.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).