From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: Re: [PATCH 07/12] util: introduce common helper for error-report & log code
Date: Wed, 20 Aug 2025 07:57:47 +1000 [thread overview]
Message-ID: <bc2a7355-355f-4207-a0de-5a7b75fe3da9@linaro.org> (raw)
In-Reply-To: <20250819202708.1185594-8-berrange@redhat.com>
On 8/20/25 06:27, Daniel P. Berrangé wrote:
> +char *qmessage_context(int flags)
> +{
> + g_autofree char *timestr = NULL;
> +
> + if ((flags & QMESSAGE_CONTEXT_SKIP_MONITOR) &&
> + monitor_cur()) {
> + return g_strdup("");
In the event we want no context, we really should avoid memory allocation too.
> + }
> +
> + if (message_format & QMESSAGE_FORMAT_TIMESTAMP) {
> + g_autoptr(GDateTime) dt = g_date_time_new_now_utc();
> + timestr = g_date_time_format_iso8601(dt);
> + }
> +
> + return g_strdup_printf("%s%s",
> + timestr ? timestr : "",
> + timestr ? " " : "");
g_strdup_printf isn't the nicest string concatenation tool.
And again, there's a no-context path.
r~
next prev parent reply other threads:[~2025-08-19 21:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 20:26 [PATCH 00/12] util: sync error_report & qemu_log output more closely Daniel P. Berrangé
2025-08-19 20:26 ` [PATCH 01/12] include: define constant for early constructor priority Daniel P. Berrangé
2025-08-19 20:26 ` [PATCH 02/12] monitor: initialize global data from a constructor Daniel P. Berrangé
2025-08-19 20:26 ` [PATCH 03/12] system: unconditionally enable thread naming Daniel P. Berrangé
2025-08-19 22:00 ` Dr. David Alan Gilbert
2025-08-19 20:27 ` [PATCH 04/12] util: set the name for the 'main' thread Daniel P. Berrangé
2025-08-19 23:18 ` Dr. David Alan Gilbert
2025-08-20 10:29 ` Daniel P. Berrangé
2025-08-19 20:27 ` [PATCH 05/12] util: add API to fetch the current thread id Daniel P. Berrangé
2025-08-19 21:38 ` Richard Henderson
2025-08-19 23:35 ` Dr. David Alan Gilbert
2025-08-20 10:47 ` Daniel P. Berrangé
2025-08-19 20:27 ` [PATCH 06/12] util: add API to fetch the current thread name Daniel P. Berrangé
2025-08-19 21:50 ` Richard Henderson
2025-08-20 10:50 ` Daniel P. Berrangé
2025-08-19 20:27 ` [PATCH 07/12] util: introduce common helper for error-report & log code Daniel P. Berrangé
2025-08-19 21:57 ` Richard Henderson [this message]
2025-08-20 11:00 ` Daniel P. Berrangé
2025-08-19 20:27 ` [PATCH 08/12] util: convert error-report & log to message API for timestamp Daniel P. Berrangé
2025-08-19 22:02 ` Richard Henderson
2025-08-20 11:12 ` Daniel P. Berrangé
2025-08-29 18:07 ` Daniel P. Berrangé
2025-08-19 20:27 ` [PATCH 09/12] util: add support for formatting a workload name in messages Daniel P. Berrangé
2025-08-19 20:27 ` [PATCH 10/12] util: add support for formatting a program " Daniel P. Berrangé
2025-08-19 20:27 ` [PATCH 11/12] util: add support for formatting thread info " Daniel P. Berrangé
2025-08-19 20:27 ` [PATCH 12/12] util: add brackets around guest name in message context Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc2a7355-355f-4207-a0de-5a7b75fe3da9@linaro.org \
--to=richard.henderson@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).