From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, qemu-block@nongnu.org, mreitz@redhat.com
Subject: Re: [PATCH v2 for-5.1 1/9] tests-qemu-opts: Cover has_help_option(), qemu_opt_has_help_opt()
Date: Wed, 15 Apr 2020 07:40:25 -0500 [thread overview]
Message-ID: <bc3dac90-889d-eb4b-0f4f-4c4e11a44be1@redhat.com> (raw)
In-Reply-To: <20200415074927.19897-2-armbru@redhat.com>
On 4/15/20 2:49 AM, Markus Armbruster wrote:
> The two turn out to be inconsistent for "a,b,,help". Test case
> marked /* BUG */.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> tests/test-qemu-opts.c | 44 ++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 44 insertions(+)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-04-15 12:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 7:49 [PATCH v2 for-5.1 0/9] qemu-option: Fix corner cases and clean up Markus Armbruster
2020-04-15 7:49 ` [PATCH v2 for-5.1 1/9] tests-qemu-opts: Cover has_help_option(), qemu_opt_has_help_opt() Markus Armbruster
2020-04-15 12:40 ` Eric Blake [this message]
2020-04-15 7:49 ` [PATCH v2 for-5.1 2/9] qemu-options: Factor out get_opt_name_value() helper Markus Armbruster
2020-04-15 7:49 ` [PATCH v2 for-5.1 3/9] qemu-option: Fix sloppy recognition of "id=..." after ", , " Markus Armbruster
2020-04-15 7:49 ` [PATCH v2 for-5.1 4/9] qemu-option: Fix has_help_option()'s sloppy parsing Markus Armbruster
2020-04-15 12:41 ` Eric Blake
2020-04-15 7:49 ` [PATCH v2 for-5.1 5/9] test-qemu-opts: Simplify test_has_help_option() after bug fix Markus Armbruster
2020-04-15 7:49 ` [PATCH v2 for-5.1 6/9] qemu-option: Avoid has_help_option() in qemu_opts_parse_noisily() Markus Armbruster
2020-04-15 7:49 ` [PATCH v2 for-5.1 7/9] qemu-img: Factor out accumulate_options() helper Markus Armbruster
2020-04-15 7:49 ` [PATCH v2 for-5.1 8/9] qemu-img: Move is_valid_option_list() to qemu-img.c and rewrite Markus Armbruster
2020-04-15 7:49 ` [PATCH v2 for-5.1 9/9] qemu-img: Reject broken -o "" Markus Armbruster
2020-04-15 12:56 ` Eric Blake
2020-04-15 9:01 ` [PATCH v2 for-5.1 0/9] qemu-option: Fix corner cases and clean up no-reply
2020-04-29 7:12 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc3dac90-889d-eb4b-0f4f-4c4e11a44be1@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).