From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59066) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q9ZtG-00025s-CI for qemu-devel@nongnu.org; Tue, 12 Apr 2011 05:28:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q9ZtB-0002Tl-NJ for qemu-devel@nongnu.org; Tue, 12 Apr 2011 05:28:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34421) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q9ZtB-0002Tf-Da for qemu-devel@nongnu.org; Tue, 12 Apr 2011 05:28:01 -0400 From: Amit Shah Date: Tue, 12 Apr 2011 14:57:40 +0530 Message-Id: In-Reply-To: References: In-Reply-To: References: Subject: [Qemu-devel] [PATCH v2 2/6] atapi: Move GET_EVENT_STATUS_NOTIFICATION command handling to its own function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu list Cc: Kevin Wolf , Juan Quintela , Stefan Hajnoczi , Markus Armbruster , Amit Shah , Paolo Bonzini This makes the code more readable. Also, there's a block like: if () { ... } else { ... } Split that into if () { ... return; } ... Signed-off-by: Amit Shah --- hw/ide/core.c | 37 ++++++++++++++++++++++++------------- 1 files changed, 24 insertions(+), 13 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index f839ef3..d71bc41 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -1084,6 +1084,29 @@ static int ide_dvd_read_structure(IDEState *s, int format, } } +static void handle_get_event_status_notification(IDEState *s, + uint8_t *buf, + const uint8_t *packet) +{ + unsigned int max_len; + + max_len = ube16_to_cpu(packet + 7); + + if (!(packet[1] & 0x01)) { /* asynchronous mode */ + /* Only polling is supported, asynchronous mode is not. */ + ide_atapi_cmd_error(s, SENSE_ILLEGAL_REQUEST, + ASC_INV_FIELD_IN_CMD_PACKET); + return; + } + + /* polling */ + /* We don't support any event class (yet). */ + cpu_to_ube16(buf, 0x00); /* No event descriptor returned */ + buf[2] = 0x80; /* No Event Available (NEA) */ + buf[3] = 0x00; /* Empty supported event classes */ + ide_atapi_cmd_reply(s, 4, max_len); +} + static void ide_atapi_cmd(IDEState *s) { const uint8_t *packet; @@ -1529,19 +1552,7 @@ static void ide_atapi_cmd(IDEState *s) break; } case GPCMD_GET_EVENT_STATUS_NOTIFICATION: - max_len = ube16_to_cpu(packet + 7); - - if (packet[1] & 0x01) { /* polling */ - /* We don't support any event class (yet). */ - cpu_to_ube16(buf, 0x00); /* No event descriptor returned */ - buf[2] = 0x80; /* No Event Available (NEA) */ - buf[3] = 0x00; /* Empty supported event classes */ - ide_atapi_cmd_reply(s, 4, max_len); - } else { /* asynchronous mode */ - /* Only polling is supported, asynchronous mode is not. */ - ide_atapi_cmd_error(s, SENSE_ILLEGAL_REQUEST, - ASC_INV_FIELD_IN_CMD_PACKET); - } + handle_get_event_status_notification(s, buf, packet); break; default: ide_atapi_cmd_error(s, SENSE_ILLEGAL_REQUEST, -- 1.7.4.2