From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67BD6EB64D8 for ; Wed, 21 Jun 2023 14:21:05 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qByhS-0008MV-4X; Wed, 21 Jun 2023 10:20:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qByhQ-0008M2-EM for qemu-devel@nongnu.org; Wed, 21 Jun 2023 10:20:44 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qByhO-0000E9-Bb for qemu-devel@nongnu.org; Wed, 21 Jun 2023 10:20:44 -0400 Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35LEIkCc020868 for ; Wed, 21 Jun 2023 14:20:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : content-transfer-encoding : mime-version; s=pp1; bh=hdh7UglbkvyeKeop2Z5KgD/YAjniUjyrUrt0C4c6APU=; b=GqBepJUmSxPUrfJfv3+4Q6M7tVuW7+Q926WR3lq/lOQ9PQQNhZb3wvFr8S9+ISomK4Cn GCvRryN0zsQWYrNPuqiCJo20868L2CS4XK7HEE1cPho4Hrk4L1mI4om4/TpDdpFDgSpS g6QqLXJkAy7IT3mANMxHo2eauGQ8xHUCygagwYz6hQrLN3+tXYh1WzP/lIctRfZ2Ej4Q 4LoLyuLZ6/JG8vAF6Ipe3A6Taaso2I+dFaQWvG+tm/84t9Zj7HPh6vTvK0hJ1laG4DDY P1YtaBnjfeKO0bLcM8PCEjXzSkc16vHFk6Q8mOWy9DTqJvRZwRRZMZ4MUTbfT41QV21+ XQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rc2urr1f6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 21 Jun 2023 14:20:40 +0000 Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 35LEKAD2025396 for ; Wed, 21 Jun 2023 14:20:40 GMT Received: from ppma04fra.de.ibm.com (6a.4a.5195.ip4.static.sl-reverse.com [149.81.74.106]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rc2urr1ec-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 21 Jun 2023 14:20:40 +0000 Received: from pps.filterd (ppma04fra.de.ibm.com [127.0.0.1]) by ppma04fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 35L5EZoX025700; Wed, 21 Jun 2023 14:20:38 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma04fra.de.ibm.com (PPS) with ESMTPS id 3r94f5a44r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 21 Jun 2023 14:20:38 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 35LEKaBD10420740 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 Jun 2023 14:20:36 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1797920043; Wed, 21 Jun 2023 14:20:36 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E175E2004D; Wed, 21 Jun 2023 14:20:35 +0000 (GMT) Received: from li-7e0de7cc-2d9d-11b2-a85c-de26c016e5ad.ibm.com (unknown [9.171.51.126]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 21 Jun 2023 14:20:35 +0000 (GMT) Message-ID: Subject: Re: [PATCH] git-submodule.sh: allow running in validate mode without previous update From: Nina Schoetterl-Glausch To: Paolo Bonzini Cc: qemu-devel Date: Wed, 21 Jun 2023 16:20:35 +0200 In-Reply-To: <31e1b43a026886e08ed48dcebbd27626eede872e.camel@linux.ibm.com> References: <20230618212039.102052-1-pbonzini@redhat.com> <31e1b43a026886e08ed48dcebbd27626eede872e.camel@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: OLJWOYfnjH4LETDcDC5qYZKwobbk84l7 X-Proofpoint-ORIG-GUID: 4dATVtYKT-VNHU4pxCH61t7uJxVaMget X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-21_08,2023-06-16_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 mlxscore=0 lowpriorityscore=0 adultscore=0 mlxlogscore=999 impostorscore=0 clxscore=1015 phishscore=0 bulkscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306210119 Received-SPF: pass client-ip=148.163.158.5; envelope-from=nsg@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, 2023-06-21 at 16:07 +0200, Nina Schoetterl-Glausch wrote: > On Tue, 2023-06-20 at 22:44 +0200, Paolo Bonzini wrote:=C2=A0 =C2=A0 =C2= =A0 =C2=A0=20 > > Il mar 20 giu 2023, 19:35 Nina Schoetterl-Glausch h= a scritto: > > > > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 modules=3D"$modules $m" > > > > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 grep $m $substat > /dev/= null 2>&1 || $GIT submodule status $module >> $substat > > > > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 else > > > > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 echo "warn: ignoring non= -existent submodule $m" > > >=20 > > > What is the rational for ignoring non-existing submodules, i.e. how d= o the arguments to > > > the script go stale as you say in the patch description? > >=20 > > For example when a Makefile calls the script before the Makefile itself= is rebuilt. >=20 > Ah thanks. Can this still happen, roms/SLOF being the only remaining buil= d time user of submodules, > as per 1f468152fb ("build: remove git submodule handling from main makefi= le")? > pc-bios/s390-ccw/Makefile explicitly names roms/SLOF, so if that were rem= oved, the Makefile would > need to be fixed anyway. >=20 > >=20 > > > I'm asking because the fedora spec file initializes a new git repo in= order to apply > > > patches so the script exits with 0. > >=20 > > You mean it succeeds even if roms/SLOF is empty? >=20 > Yeah, it does: >=20 > %prep > %autosetup -n qemu-%{version}%{?rcstr} -S git_am >=20 > Which I does a git init, git add ., git commit, so no submodules exist an= d git-submodule.sh ignores > every maybe_module. >=20 > Not a problem with qemu, I'm just wondering if this behavior is still the= most sensible for git-submodule.sh Also the official source tar does include roms/SLOF, so they won't run into= problems. I used the spec file with a tar generated by archive-source.sh which doesn'= t package roms/SLOF. How is the official tar generated? >=20 >=20 > [...]