From: Cleber Rosa <crosa@redhat.com>
To: Caio Carrara <ccarrara@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 1/2] tests.acceptance: adds multi vm capability for acceptance tests
Date: Mon, 18 Feb 2019 12:55:24 -0500 [thread overview]
Message-ID: <bc4bb11c-cb07-bfcc-3727-812312294229@redhat.com> (raw)
In-Reply-To: <20190212193855.13223-2-ccarrara@redhat.com>
On 2/12/19 2:38 PM, Caio Carrara wrote:
> This change adds the possibility to write acceptance tests with multi
> virtual machine support. It's done keeping the virtual machines objects
> stored in a test attribute (dictionary). This dictionary shouldn't be
> accessed directly but through the new method added `get_vm`. This new
> method accept a list of args (that will be added as virtual machine
> arguments) and an optional name argument. The name is the key that
> identify a single virtual machine along the test machines available. If
> a name without a machine is informed a new machine will be instantiated.
>
> The current usage of vm in tests will not be broken by this change since
> it keeps a property called vm in the base test class. This property only
> calls the new method `get_vm` with default parameters (no args and
> 'default' as machine name).
>
> Signed-off-by: Caio Carrara <ccarrara@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
next prev parent reply other threads:[~2019-02-18 17:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 19:38 [Qemu-devel] [PATCH v3 0/2] tests.acceptance: adds multi vm capability and basic migration test Caio Carrara
2019-02-12 19:38 ` [Qemu-devel] [PATCH v3 1/2] tests.acceptance: adds multi vm capability for acceptance tests Caio Carrara
2019-02-18 17:55 ` Cleber Rosa [this message]
2019-02-12 19:38 ` [Qemu-devel] [PATCH v3 2/2] tests.acceptance: adds simple migration test Caio Carrara
2019-02-18 17:56 ` Cleber Rosa
2019-02-21 14:14 ` [Qemu-devel] [PATCH v3 0/2] tests.acceptance: adds multi vm capability and basic " Wainer dos Santos Moschetta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc4bb11c-cb07-bfcc-3727-812312294229@redhat.com \
--to=crosa@redhat.com \
--cc=ccarrara@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).