qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] vfio-pci: enable by default
Date: Sun, 10 Mar 2019 07:33:49 -0300	[thread overview]
Message-ID: <bc54c197-b87c-c4a9-8c93-d32dafaa6e27@gmail.com> (raw)
In-Reply-To: <20190308173622.21386-1-pbonzini@redhat.com>

Just faced this problem when trying to test vfio-pci using upstream:

qemu-system-ppc64: -device vfio-pci,host=0035:03:00.0,id=hostdev8: 
'vfio-pci' is not a valid device model name


This patch fixed it.

Tested-by: Daniel Henrique Barboza <danielhb413@gmail.com>


On 3/8/19 2:36 PM, Paolo Bonzini wrote:
> CONFIG_VFIO_PCI was not "default y" - and once you do that, it is also important
> to disable it if PCI is not there.
>
> Reported-by: Alex Williamson <alex.williamson@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   hw/vfio/Kconfig | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/vfio/Kconfig b/hw/vfio/Kconfig
> index ebda9fdf22..34da2a3cfd 100644
> --- a/hw/vfio/Kconfig
> +++ b/hw/vfio/Kconfig
> @@ -4,8 +4,9 @@ config VFIO
>   
>   config VFIO_PCI
>       bool
> +    default y
>       select VFIO
> -    depends on LINUX
> +    depends on LINUX && PCI
>   
>   config VFIO_CCW
>       bool

      parent reply	other threads:[~2019-03-10 10:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-08 17:36 [Qemu-devel] [PATCH] vfio-pci: enable by default Paolo Bonzini
2019-03-08 17:46 ` Alex Williamson
2019-03-10 10:33 ` Daniel Henrique Barboza [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc54c197-b87c-c4a9-8c93-d32dafaa6e27@gmail.com \
    --to=danielhb413@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).