From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ABF7C433EF for ; Wed, 13 Oct 2021 22:34:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A352F610CC for ; Wed, 13 Oct 2021 22:34:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A352F610CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:50938 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mampA-0004YU-JM for qemu-devel@archiver.kernel.org; Wed, 13 Oct 2021 18:34:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55020) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mamnT-00039i-Pg for qemu-devel@nongnu.org; Wed, 13 Oct 2021 18:32:27 -0400 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]:52184) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mamnS-0000xU-41 for qemu-devel@nongnu.org; Wed, 13 Oct 2021 18:32:27 -0400 Received: by mail-pj1-x102e.google.com with SMTP id kk10so3360207pjb.1 for ; Wed, 13 Oct 2021 15:32:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=552Hf7L9o2Y8cHcQZpKeiRqBO0zhIx9uYw3umQfq/dU=; b=V2csutUEVbNGynsOj+tgn1XeJIG6d+mFir/ZZ0H3CHMhI01Gg7J+az285thlMdDfb2 ED85Pp4AgkLkVc1DBCAk29G+Jd4cDUc36XB5FdhmHNXb6VKquYpS62q5eJazIrWSsd+7 L50rhao/c0TPp/gUOeC50lMarGDF/GPmedbr+xIemc5coGy1487jq8LGtn1wwRr465uD UfB5VKzRxYIIZKyi+OPTQWIL/HzL12CAAEFAJKe4ihWGpv1OFauTBykUAWlwNWdkmMLF p1zXcfg7MlCVnZ9Z4DkveeKwUWNrRqZ3W6ewesFD4PbT35hdCxAbqra33ZxaT6UsOAgJ vAcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=552Hf7L9o2Y8cHcQZpKeiRqBO0zhIx9uYw3umQfq/dU=; b=TrahvlLBN3m7nulwDxYsYc0XNgNEWtdJoK2zQUGQLCVR+J87LBM0gfo8Qxzh4Tibvz BZANncCds0m0YZKE2n731AMrqPiNCa0PFkDMgKt/L64+fRIt5Ca7W5Ta0Ysdw+/VOlMi qKKXTrQZU7IAlEaew7+Rw3/Qje9Ci3EcBNZlQkezHVoFCWyGCI0AKG9OQvCjPuxJhVfF emzt2EmwVTvDWLX9bSYwGsjSBJvfIQkCkecIOg9QBJY0O3ahxcTM5VM6WxsMT6anOkCx mhu7+kSRVAqnTU/O7G3NuwlolpfG4nfj2l58/ScCTgod4jMwxOEV6x90FqskZkUWT/8H U9Dg== X-Gm-Message-State: AOAM530SeNXkipbPi4pHCRLK+JIS0Y75JrOfnwwiey3bcGszijLbBo07 NcxmoYS/nQtjUCz55LgcHB7kzQ== X-Google-Smtp-Source: ABdhPJyodH51ncsgVEDoMlGbAa/GkKIXCRIjHimGqwix/cRZEUtMPMMfmGQlbzRGfw3kMNJNN7f4bQ== X-Received: by 2002:a17:90b:4b03:: with SMTP id lx3mr2197543pjb.162.1634164343803; Wed, 13 Oct 2021 15:32:23 -0700 (PDT) Received: from [192.168.1.11] ([71.212.134.125]) by smtp.gmail.com with ESMTPSA id m12sm465211pjv.29.2021.10.13.15.32.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Oct 2021 15:32:23 -0700 (PDT) Subject: Re: [RFC PATCH] target/mips: Fix DEXTRV_S.H DSP opcode To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20211013215652.1764551-1-f4bug@amsat.org> From: Richard Henderson Message-ID: Date: Wed, 13 Oct 2021 15:32:21 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211013215652.1764551-1-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::102e; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Rikalo , Aurelien Jarno , Jia Liu Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/13/21 2:56 PM, Philippe Mathieu-Daudé wrote: > While for the DEXTR_S.H opcode: > > "The shift argument is provided in the instruction." > > For the DEXTRV_S.H opcode we have: > > "The five least-significant bits of register rs provide the > shift argument, interpreted as a five-bit unsigned integer; > the remaining bits in rs are ignored." > > While 't1' contains the 'rs' register content (the shift value > for DEXTR_S.H), we need to load the value of 'rs' for DEXTRV_S.H. > We can directly use the v1_t TCG register which already contains > this shift value. > > Fixes: b53371ed5d4 ("target-mips: Add ASE DSP accumulator instructions") > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/tcg/translate.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Richard Henderson r~