From: Richard Henderson <richard.henderson@linaro.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Laszlo Ersek <lersek@redhat.com>,
qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH v9 1/5] hw/nvram/fw_cfg: Add the FW_CFG_DATA_GENERATOR interface
Date: Sat, 20 Jun 2020 10:52:43 -0700 [thread overview]
Message-ID: <bc57c3d1-020e-8e48-228d-c9a31104ab3a@linaro.org> (raw)
In-Reply-To: <20200616153122.GN550360@redhat.com>
On 6/16/20 8:31 AM, Daniel P. Berrangé wrote:
> fw_cfg_add_file(s, filename, g_byte_array_steal(data, NULL),
> (guint)g_byte_array_get_size(data));
FWIW, you can't both read the size and steal the data in the argument list like
this -- the evaluation order is unspecified.
r~
next prev parent reply other threads:[~2020-06-20 17:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 10:34 [PATCH v9 0/5] fw_cfg: Add FW_CFG_DATA_GENERATOR; crypto: Add tls-cipher-suites Philippe Mathieu-Daudé
2020-06-15 10:34 ` [PATCH v9 1/5] hw/nvram/fw_cfg: Add the FW_CFG_DATA_GENERATOR interface Philippe Mathieu-Daudé
2020-06-16 15:31 ` Daniel P. Berrangé
2020-06-20 17:52 ` Richard Henderson [this message]
2020-06-22 13:54 ` Philippe Mathieu-Daudé
2020-06-22 14:08 ` Daniel P. Berrangé
2020-06-15 10:34 ` [PATCH v9 2/5] softmmu/vl: Let -fw_cfg option take a 'gen_id' argument Philippe Mathieu-Daudé
2020-06-15 10:34 ` [PATCH v9 3/5] softmmu/vl: Allow -fw_cfg 'gen_id' option to use the 'etc/' namespace Philippe Mathieu-Daudé
2020-06-15 10:34 ` [PATCH v9 4/5] crypto: Add tls-cipher-suites object Philippe Mathieu-Daudé
2020-06-16 16:32 ` Daniel P. Berrangé
2020-06-15 10:34 ` [PATCH v9 5/5] crypto/tls-cipher-suites: Produce fw_cfg consumable blob Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc57c3d1-020e-8e48-228d-c9a31104ab3a@linaro.org \
--to=richard.henderson@linaro.org \
--cc=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).