From: Richard Henderson <richard.henderson@linaro.org>
To: Anton Johansson <anjo@rev.ng>, qemu-devel@nongnu.org
Cc: ale@rev.ng, pbonzini@redhat.com, eduardo@habkost.net,
philmd@linaro.org, marcel.apfelbaum@gmail.com,
peter.maydell@linaro.org, wangyanan55@huawei.com
Subject: Re: [PATCH 5/9] accel: Move CPUTLB to CPUState and assert offset
Date: Fri, 30 Jun 2023 16:16:21 +0200 [thread overview]
Message-ID: <bc65acdc-b32d-0f0f-82c3-b2143c9af6e9@linaro.org> (raw)
In-Reply-To: <20230630122551.21766-6-anjo@rev.ng>
On 6/30/23 14:25, Anton Johansson wrote:
> @@ -448,6 +448,13 @@ struct CPUState {
>
> /* track IOMMUs whose translations we've cached in the TCG TLB */
> GArray *iommu_notifiers;
> +
> + /*
> + * The following fields needs to be within CPU_MAX_NEGATIVE_ENV_OFFSET of
> + * CPUArchState. As CPUArchState is assumed to follow CPUState in the
> + * ArchCPU struct these are placed last. This is checked statically.
> + */
> + CPUTLB tlb;
> };
This is what we had before CPUNegativeOffsetState, comment and all, and over the course of
time the comment was ignored and the CPUTLB crept toward the middle of the structure.
I really don't see how this merge helps. There's nothing target-specific about
CPUTLBDescFast or CPUNegativeOffsetState, and keeping them separate enforces their importance.
r~
next prev parent reply other threads:[~2023-06-30 14:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 12:25 [PATCH 0/9] Collapse CPUNegativeOffsetState into CPUState Anton Johansson via
2023-06-30 12:25 ` [PATCH 1/9] target/arm: Replace TARGET_PAGE_ENTRY_EXTRA Anton Johansson via
2023-06-30 12:25 ` [PATCH 2/9] include: Move MMUAccessType to tlb-common.h Anton Johansson via
2023-06-30 12:25 ` [PATCH 3/9] include/exec: Move CPUTLB and friends " Anton Johansson via
2023-06-30 12:25 ` [PATCH 4/9] include/hw: introduce CPU_MAX_NEGATIVE_ENV_OFFSET Anton Johansson via
2023-06-30 14:19 ` Richard Henderson
2023-07-04 8:49 ` Anton Johansson via
2023-06-30 12:25 ` [PATCH 5/9] accel: Move CPUTLB to CPUState and assert offset Anton Johansson via
2023-06-30 14:16 ` Richard Henderson [this message]
2023-07-04 8:45 ` Anton Johansson via
2023-06-30 12:25 ` [PATCH 6/9] Move IcountDecr " Anton Johansson via
2023-06-30 12:25 ` [PATCH 7/9] include/exec: Remove [cpu|env]_neg() functions Anton Johansson via
2023-06-30 12:25 ` [PATCH 8/9] target: Remove CPUNegativeOffsetState field from ArchCPU Anton Johansson via
2023-06-30 12:25 ` [PATCH 9/9] include/exec: Remove CPUNegativeOffsetState Anton Johansson via
2023-07-01 9:21 ` [PATCH 0/9] Collapse CPUNegativeOffsetState into CPUState Paolo Bonzini
2023-07-04 8:54 ` Anton Johansson via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc65acdc-b32d-0f0f-82c3-b2143c9af6e9@linaro.org \
--to=richard.henderson@linaro.org \
--cc=ale@rev.ng \
--cc=anjo@rev.ng \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).