From: Eric Blake <eblake@redhat.com>
To: Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com>,
Greg Kurz <groug@kaod.org>,
pradeepkiruvale@gmail.com
Cc: berto@igalia.com, famz@redhat.com, qemu-devel@nongnu.org,
aneesh.kumar@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH 0/2 V13] fsdev: add IO throttle support to fsdev devices
Date: Mon, 23 Jan 2017 10:34:31 -0600 [thread overview]
Message-ID: <bc76a7c9-2951-ff8c-4174-46f8fbc65d47@redhat.com> (raw)
In-Reply-To: <3478b86e-7a32-5e92-58cc-1cfe7ccecb41@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 926 bytes --]
On 01/23/2017 10:30 AM, Pradeep Jagadeesh wrote:
> On 1/23/2017 5:22 PM, Greg Kurz wrote:
>> On Mon, 23 Jan 2017 08:03:18 -0800 (PST)
>> no-reply@patchew.org wrote:
>>> Hi,
>>>
>>> Your series seems to have some coding style problems. See output
>>> below for
>>> more information:
>>>
>>
> Ya, I observed signoff issue. I have created next version files.
> I will send them tomorrow.
>
> But, I do not know how to solve the second warning.
> i.e multi line macro issue.
I don't think there is anything to fix there; it is a false positive
from checkpatch.pl (unless you want to dive in to the perl script and
figure out how to relax it to allow that usage, as you are not the first
to have it). Documenting in the commit message that checkpatch has a
false-positive warning is acceptable.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-01-23 16:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 15:50 [Qemu-devel] [PATCH 0/2 V13] fsdev: add IO throttle support to fsdev devices Pradeep Jagadeesh
2017-01-23 15:50 ` [Qemu-devel] [PATCH 1/2 " Pradeep Jagadeesh
2017-01-23 15:50 ` [Qemu-devel] [PATCH 2/2 V13] throttle: factor out duplicate code Pradeep Jagadeesh
2017-01-23 15:55 ` Eric Blake
2017-01-23 15:59 ` Pradeep Jagadeesh
2017-01-23 16:03 ` [Qemu-devel] [PATCH 0/2 V13] fsdev: add IO throttle support to fsdev devices no-reply
2017-01-23 16:22 ` Greg Kurz
2017-01-23 16:30 ` Pradeep Jagadeesh
2017-01-23 16:34 ` Eric Blake [this message]
2017-01-23 16:41 ` Pradeep Jagadeesh
2017-01-23 16:42 ` Greg Kurz
-- strict thread matches above, loose matches on Subject: below --
2017-01-23 15:40 Pradeep Jagadeesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc76a7c9-2951-ff8c-4174-46f8fbc65d47@redhat.com \
--to=eblake@redhat.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=berto@igalia.com \
--cc=famz@redhat.com \
--cc=groug@kaod.org \
--cc=pradeep.jagadeesh@huawei.com \
--cc=pradeepkiruvale@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).