Re: [Qemu-devel] [Qemu-block] qemu-iotests 069 and 111 are failing on NetBSD

[John Snow <jsnow@redhat.com>]

On 8/13/19 3:57 AM, Paolo Bonzini wrote:
> On 13/08/19 08:17, Thomas Huth wrote:
>> On 8/12/19 9:16 PM, John Snow wrote:
>>>
>>>
>>> On 7/25/19 4:34 AM, Thomas Huth wrote:
>>>> On 24/07/2019 18.29, Paolo Bonzini wrote:
>>>>> On 24/07/19 11:34, Thomas Huth wrote:
>>>>>> In case somebody is interested, two of the "auto" iotests are failing
>>>>>> on NetBSD due to non-matching output:
>>>>>>
>>>>>>   TEST    iotest-qcow2: 069 [fail]
>>>>>> --- /var/tmp/qemu-test.1BMupF/tests/qemu-iotests/069.out        2019-07-24 09:19:22.000000000 +0000
>>>>>> +++ /var/tmp/qemu-test.1BMupF/tests/qemu-iotests/069.out.bad    2019-07-24 09:21:34.000000000 +0000
>>>>>> @@ -4,5 +4,5 @@
>>>>>>  
>>>>>>  Formatting 'TEST_DIR/t.IMGFMT.base', fmt=IMGFMT size=131072
>>>>>>  Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=131072 backing_file=TEST_DIR/t.IMGFMT.base
>>>>>> -qemu-io: can't open device TEST_DIR/t.IMGFMT: Could not open backing file: Could not open 'TEST_DIR/t.IMGFMT.base': No such file or directory
>>>>>> +qemu-io: can't open device TEST_DIR/t.IMGFMT: Could not open backing file: TEST_DIR/t.IMGFMT.base: stat failed: No such file or directory
>>>>>>  *** done
>>>>>>
>>>>>> and:
>>>>>>
>>>>>>   TEST    iotest-qcow2: 111 [fail]
>>>>>> --- /var/tmp/qemu-test.1BMupF/tests/qemu-iotests/111.out        2019-07-24 09:19:22.000000000 +0000
>>>>>> +++ /var/tmp/qemu-test.1BMupF/tests/qemu-iotests/111.out.bad    2019-07-24 09:21:40.000000000 +0000
>>>>>> @@ -1,4 +1,4 @@
>>>>>>  QA output created by 111
>>>>>> -qemu-img: TEST_DIR/t.IMGFMT: Could not open 'TEST_DIR/t.IMGFMT.inexistent': No such file or directory
>>>>>> +qemu-img: TEST_DIR/t.IMGFMT: TEST_DIR/t.IMGFMT.inexistent: stat failed: No such file or directory
>>>>>>  Could not open backing image to determine size.
>>>>>>  *** done
>>>>>>
>>>>>> It's currently not a problem yet since we're not running the
>>>>>> iotests on NetBSD yet (since our netbsd VM image does not have
>>>>>> bash and gsed installed yet), but if somebody has some spare
>>>>>> minutes, it would be great if this could be fixed so that we
>>>>>> can enable the iotests on NetBSD, too, one day...
>>>>>
>>>>> Is this (slightly ridiculous but effective) patch enough?
>>>>>
>>>>> diff --git a/block/file-posix.c b/block/file-posix.c
>>>>> index 73a001ceb7..ce847f4d62 100644
>>>>> --- a/block/file-posix.c
>>>>> +++ b/block/file-posix.c
>>>>> @@ -217,7 +217,7 @@ static int raw_normalize_devicepath(const char **filename, Error **errp)
>>>>>      fname = *filename;
>>>>>      dp = strrchr(fname, '/');
>>>>>      if (lstat(fname, &sb) < 0) {
>>>>> -        error_setg_errno(errp, errno, "%s: stat failed", fname);
>>>>> +        error_setg_errno(errp, errno, "Could not open: '%s'", fname);
>>>>>          return -errno;
>>>>>      }
>>>>
>>>> Yes, good idea! It works after removing the colon after "open"! :-)
>>>>
>>>> With the colon removed:
>>>>
>>>> Tested-by: Thomas Huth <thuth@redhat.com>
>>>>
>>>>  Thomas
>>>>
>>>
>>> Does someone intend to submit this patch formally?
>>
>> Yes, Paolo did it:
>>
>>  https://www.mail-archive.com/qemu-devel@nongnu.org/msg633351.html
> 
> I can also include it in my pull request for 4.2.
> 
> Paolo
> 

Thanks, I had just missed it.

(Re: discussions on patch management processes: this is a pain point I
have about the email based workflow is that the fate of individual
threads is not always immediately clear.)

--js