From: Thomas Huth <thuth@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Hanna Reitz" <hreitz@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [PATCH 3/4] tests: add nbd and luks to the I/O test suites
Date: Wed, 8 Oct 2025 13:55:12 +0200 [thread overview]
Message-ID: <bc904027-5b58-4057-8ef5-15e4ebcca767@redhat.com> (raw)
In-Reply-To: <20251008113552.747002-4-berrange@redhat.com>
On 08/10/2025 13.35, Daniel P. Berrangé wrote:
> This introduces new suits for running I/O tests on NBD and LUKS
> drivers, giving new make targets
>
> * make check-block-luks
> * make check-block-nbd
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> tests/qemu-iotests/meson.build | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/meson.build b/tests/qemu-iotests/meson.build
> index 939a14ffae..5735d67c8c 100644
> --- a/tests/qemu-iotests/meson.build
> +++ b/tests/qemu-iotests/meson.build
> @@ -23,7 +23,9 @@ qemu_iotests_formats = {
> 'raw': 'slow',
> 'qed': 'thorough',
> 'vmdk': 'thorough',
> - 'vpc': 'thorough'
> + 'vpc': 'thorough',
> + 'nbd': 'thorough',
> + 'luks': 'thorough',
> }
Before we do that, I'd first see a solution for the problem that I described
in my series here:
https://lore.kernel.org/qemu-devel/20250910153727.226217-1-thuth@redhat.com/
which, by the way, contains a patch that is very similar to yours here.
Also not sure whether we should add "nbd" to the "formats" list - it's a
protocol, and not a format, isn't it?
Thomas
next prev parent reply other threads:[~2025-10-08 11:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-08 11:35 [PATCH 0/4] tests: do more testing of block drivers in CI Daniel P. Berrangé
2025-10-08 11:35 ` [PATCH 1/4] tests: print reason when I/O test is skipped in TAP mode Daniel P. Berrangé
2025-10-08 11:47 ` Thomas Huth
2025-10-08 11:35 ` [PATCH 2/4] tests: rearrange suites for I/O tests Daniel P. Berrangé
2025-10-14 8:26 ` Kevin Wolf
2025-10-08 11:35 ` [PATCH 3/4] tests: add nbd and luks to the I/O test suites Daniel P. Berrangé
2025-10-08 11:55 ` Thomas Huth [this message]
2025-10-08 12:55 ` Daniel P. Berrangé
2025-10-08 13:03 ` Thomas Huth
2025-10-08 15:55 ` Eric Blake
2025-10-14 8:50 ` Kevin Wolf
2025-10-08 15:49 ` Eric Blake
2025-10-08 11:35 ` [PATCH RFC/WIP 4/4] gitlab: add jobs for thorough block tests Daniel P. Berrangé
2025-10-08 15:57 ` Eric Blake
2025-10-08 16:23 ` Daniel P. Berrangé
2025-10-13 21:46 ` Eric Blake
2025-10-10 11:55 ` Thomas Huth
2025-10-10 12:11 ` Daniel P. Berrangé
2025-10-08 16:28 ` [PATCH 0/4] tests: do more testing of block drivers in CI Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc904027-5b58-4057-8ef5-15e4ebcca767@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).