From: Thomas Huth <thuth@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for 4.2 1/3] glib: bump min required glib library version to 2.48
Date: Tue, 23 Jul 2019 18:02:43 +0200 [thread overview]
Message-ID: <bc905731-fa27-83ee-bc31-19b01fb797c9@redhat.com> (raw)
In-Reply-To: <20190723154856.17348-2-berrange@redhat.com>
On 23/07/2019 17.48, Daniel P. Berrangé wrote:
> Per supported platforms doc[1], the various min glib on relevant distros is:
>
> RHEL-8: 2.56.1
> RHEL-7: 2.50.3
> Debian (Buster): 2.58.3
> Debian (Stretch): 2.50.3
> OpenBSD (Ports): 2.58.3
> FreeBSD (Ports): 2.56.3
> OpenSUSE Leap 15: 2.54.3
> SLE12-SP2: 2.48.2
> Ubuntu (Xenial): 2.48.0
> macOS (Homebrew): 2.56.0
>
> This suggests that a minimum glib of 2.48 is a reasonable target.
>
> Compared to the previous version bump in
>
> commit e7b3af81597db1a6b55f2c15d030d703c6b2c6ac
> Author: Daniel P. Berrangé <berrange@redhat.com>
> Date: Fri May 4 15:34:46 2018 +0100
>
> glib: bump min required glib library version to 2.40
>
> This will result in us dropping support for Debian Jessie and
> Ubuntu 14.04.
>
> As per the commit message 14.04 was already outside our list
> of supported build platforms and an exception was only made
> because one of the build hosts used during merge testing was
> stuck on 14.04.
>
> Debian Jessie is justified to drop because we only aim to
> support at most 2 major versions of Debian at any time. This
> means Buster and Stretch at this time.
>
> The g_strv_contains compat code is dropped as this API is
> present since 2.44
>
> The g_assert_cmpmem compat code is dropped as this API is
> present since 2.46
>
> [1] https://qemu.weilnetz.de/doc/qemu-doc.html#Supported-build-platforms
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
Sorry, my memory fails ... when did I review this patch?
Thomas
next prev parent reply other threads:[~2019-07-23 16:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 15:48 [Qemu-devel] [PATCH for 4.2 0/3] require newer glib2 to enable autofree'ing of stack variables exiting scope Daniel P. Berrangé
2019-07-23 15:48 ` [Qemu-devel] [PATCH for 4.2 1/3] glib: bump min required glib library version to 2.48 Daniel P. Berrangé
2019-07-23 16:02 ` Thomas Huth [this message]
2019-07-23 16:04 ` Daniel P. Berrangé
2019-07-23 15:48 ` [Qemu-devel] [PATCH for 4.2 2/3] crypto: define cleanup functions for use with g_autoptr Daniel P. Berrangé
2019-07-23 15:48 ` [Qemu-devel] [PATCH for 4.2 3/3] crypto: use auto cleanup for many stack variables Daniel P. Berrangé
2019-07-23 19:17 ` [Qemu-devel] [PATCH for 4.2 0/3] require newer glib2 to enable autofree'ing of stack variables exiting scope no-reply
2019-07-25 8:38 ` Stefan Hajnoczi
2019-07-25 9:13 ` Peter Maydell
2019-07-25 9:24 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc905731-fa27-83ee-bc31-19b01fb797c9@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).