From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33970C678D4 for ; Wed, 1 Mar 2023 19:43:22 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXSLa-0003j5-NA; Wed, 01 Mar 2023 14:42:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXSLX-0003iq-Ox for qemu-devel@nongnu.org; Wed, 01 Mar 2023 14:42:39 -0500 Received: from forwardcorp1c.mail.yandex.net ([178.154.239.200]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXSLW-0005lm-34 for qemu-devel@nongnu.org; Wed, 01 Mar 2023 14:42:39 -0500 Received: from mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net [IPv6:2a02:6b8:c12:57a5:0:640:1f49:0]) by forwardcorp1c.mail.yandex.net (Yandex) with ESMTP id 746C95E98C; Wed, 1 Mar 2023 22:42:30 +0300 (MSK) Received: from [IPV6:2a02:6b8:b081:b415::1:1a] (unknown [2a02:6b8:b081:b415::1:1a]) by mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id QgbSb60OgGk0-FKwYkBI4; Wed, 01 Mar 2023 22:42:29 +0300 Precedence: bulk X-Yandex-Fwd: 1 Authentication-Results: mail-nwsmtp-smtp-corp-main-62.myt.yp-c.yandex.net; dkim=pass Message-ID: Date: Wed, 1 Mar 2023 21:42:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 1/1] vhost-user-fs: add migration type property Content-Language: en-US, ru-RU To: Stefan Hajnoczi Cc: "Michael S. Tsirkin" , Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, yc-core@yandex-team.ru, "Dr. David Alan Gilbert" , Markus Armbruster , Eduardo Habkost , Juan Quintela , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Paolo Bonzini , virtio-fs@redhat.com, Eric Blake References: <20230223023604-mutt-send-email-mst@kernel.org> <20230224034258-mutt-send-email-mst@kernel.org> <8611d901-0940-3747-c2cd-9c193c7f24f2@yandex-team.ru> <20230228094756-mutt-send-email-mst@kernel.org> <20230228161602-mutt-send-email-mst@kernel.org> <20230301094424-mutt-send-email-mst@kernel.org> <39577b2c-71ec-5e83-d796-2c4fe3d1fc10@yandex-team.ru> <20230301104316-mutt-send-email-mst@kernel.org> From: Anton Kuchin In-Reply-To: <20230301104316-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=178.154.239.200; envelope-from=antonkuchin@yandex-team.ru; helo=forwardcorp1c.mail.yandex.net X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.09, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 01/03/2023 17:52, Michael S. Tsirkin wrote: > On Wed, Mar 01, 2023 at 05:40:09PM +0200, Anton Kuchin wrote: >> So catching errors in not the only purpose of this property, but it >> definitely >> allows us to catch some obvious ones. > OK let's say this. If migration=external then migration just works. > If migration=internal it fails for now. We are agreed here right? > > Our argument is whether to check on load or save? > > I propose this compromize: two properties: > migration-load and migration-save > > migration-load : how is incoming migration handled. > internal - through qemu > external - through the daemon > > checked in pre-load > > migration-save : how is outgoing migration handled. > internal - through qemu > external - through the daemon > > checked in post-save > > This way whether the check is on source or destination or both > is up to the user. > > Hmm? Stefan, what do you think about this idea?