From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36635) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPDgZ-00082l-IC for qemu-devel@nongnu.org; Tue, 20 Nov 2018 16:35:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPDgX-0003Ay-DZ for qemu-devel@nongnu.org; Tue, 20 Nov 2018 16:35:55 -0500 References: <20181105014047.26447-1-sameo@linux.intel.com> <20181116172919.43f3e27d@redhat.com> <20181119163110.2f357f40@redhat.com> <20181119131314-mutt-send-email-mst@kernel.org> From: Paolo Bonzini Message-ID: Date: Tue, 20 Nov 2018 22:35:27 +0100 MIME-Version: 1.0 In-Reply-To: <20181119131314-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Igor Mammedov , Samuel Ortiz , qemu-devel@nongnu.org, Peter Maydell , Stefano Stabellini , Eduardo Habkost , Shannon Zhao , qemu-arm@nongnu.org, Anthony Perard , xen-devel@lists.xenproject.org, Richard Henderson On 19/11/18 19:14, Michael S. Tsirkin wrote: > On Mon, Nov 19, 2018 at 06:14:26PM +0100, Paolo Bonzini wrote: >> On 19/11/18 16:31, Igor Mammedov wrote: >>> I've tried to give suggestions how to restructure series >>> on per patch basis. In my opinion it quite possible to split >>> series in several smaller ones and it should really help with >>> making series cleaner and easier/faster to review/amend/merge >>> vs what we have in v5. >> >> This is true, on the other hand the series makes sense together and, >> even if the patches are more or less independent, they also all follow >> the same "plan". For reviewing v6, are you aware of Patchew's series >> diff functionality? It can tell you which patches had comments in v5, >> reorder patches if applicable, and display deleted and new patches at >> the right point in the series. >> >> v4->v5 is a bit messed up because Samuel probably added a diff order >> setup >> (https://patchew.org/QEMU/20181101102303.16439-1-sameo@linux.intel.com/diff/20181105014047.26447-1-sameo@linux.intel.com/) >> but it's very useful in general. >> >> Paolo > > Oh I didn't realize difforder breaks patchew. Or is the problem > only if one switches from no order to difforder? No, it's just that switching it on makes the inter-version diff much larger, because all hunks are reordered. difforder is not a problem. Paolo