From: "Cédric Le Goater" <clg@kaod.org>
To: Joel Stanley <joel@jms.id.au>,
Peter Maydell <peter.maydell@linaro.org>,
Andrew Jeffery <andrew@aj.id.au>
Cc: Patrick Venture <venture@google.com>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] arm/aspeed: rainier: Add i2c eeproms and muxes
Date: Fri, 25 Jun 2021 10:36:09 +0200 [thread overview]
Message-ID: <bca2e943-4fa1-ea16-439f-40d8681cfeef@kaod.org> (raw)
In-Reply-To: <20210625050643.161042-1-joel@jms.id.au>
On 6/25/21 7:06 AM, Joel Stanley wrote:
> These are the devices documented by the Rainier device tree. With this
> we can see the guest discovering the multiplexers and probing the eeprom
> devices:
>
> i2c i2c-2: Added multiplexed i2c bus 16
> i2c i2c-2: Added multiplexed i2c bus 17
> i2c i2c-2: Added multiplexed i2c bus 18
> i2c i2c-2: Added multiplexed i2c bus 19
> i2c-mux-gpio i2cmux: 4 port mux on 1e78a180.i2c-bus adapter
> at24 20-0050: 8192 byte 24c64 EEPROM, writable, 1 bytes/write
> i2c i2c-4: Added multiplexed i2c bus 20
> at24 21-0051: 8192 byte 24c64 EEPROM, writable, 1 bytes/write
> i2c i2c-4: Added multiplexed i2c bus 21
> at24 22-0052: 8192 byte 24c64 EEPROM, writable, 1 bytes/write
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Thanks,
C.
> ---
> hw/arm/aspeed.c | 56 +++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 56 insertions(+)
>
> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
> index 1301e8fdffb2..7ed22294c6eb 100644
> --- a/hw/arm/aspeed.c
> +++ b/hw/arm/aspeed.c
> @@ -677,6 +677,10 @@ static void g220a_bmc_i2c_init(AspeedMachineState *bmc)
> static void rainier_bmc_i2c_init(AspeedMachineState *bmc)
> {
> AspeedSoCState *soc = &bmc->soc;
> + I2CSlave *i2c_mux;
> +
> + smbus_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 0), 0x51,
> + g_malloc0(32 * 1024));
>
> /* The rainier expects a TMP275 but a TMP105 is compatible */
> i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 4), TYPE_TMP105,
> @@ -685,11 +689,25 @@ static void rainier_bmc_i2c_init(AspeedMachineState *bmc)
> 0x49);
> i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 4), TYPE_TMP105,
> 0x4a);
> + i2c_mux = i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 4),
> + "pca9546", 0x70);
> + smbus_eeprom_init_one(pca954x_i2c_get_bus(i2c_mux, 0), 0x50,
> + g_malloc0(64 * 1024));
> + smbus_eeprom_init_one(pca954x_i2c_get_bus(i2c_mux, 1), 0x51,
> + g_malloc0(64 * 1024));
> + smbus_eeprom_init_one(pca954x_i2c_get_bus(i2c_mux, 2), 0x52,
> + g_malloc0(64 * 1024));
>
> i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 5), TYPE_TMP105,
> 0x48);
> i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 5), TYPE_TMP105,
> 0x49);
> + i2c_mux = i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 5),
> + "pca9546", 0x70);
> + smbus_eeprom_init_one(pca954x_i2c_get_bus(i2c_mux, 0), 0x50,
> + g_malloc0(64 * 1024));
> + smbus_eeprom_init_one(pca954x_i2c_get_bus(i2c_mux, 1), 0x51,
> + g_malloc0(64 * 1024));
>
> i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 6), TYPE_TMP105,
> 0x48);
> @@ -697,6 +715,16 @@ static void rainier_bmc_i2c_init(AspeedMachineState *bmc)
> 0x4a);
> i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 6), TYPE_TMP105,
> 0x4b);
> + i2c_mux = i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 6),
> + "pca9546", 0x70);
> + smbus_eeprom_init_one(pca954x_i2c_get_bus(i2c_mux, 0), 0x50,
> + g_malloc0(64 * 1024));
> + smbus_eeprom_init_one(pca954x_i2c_get_bus(i2c_mux, 1), 0x51,
> + g_malloc0(64 * 1024));
> + smbus_eeprom_init_one(pca954x_i2c_get_bus(i2c_mux, 2), 0x50,
> + g_malloc0(64 * 1024));
> + smbus_eeprom_init_one(pca954x_i2c_get_bus(i2c_mux, 3), 0x51,
> + g_malloc0(64 * 1024));
>
> /* Bus 7: TODO dps310@76 */
> /* Bus 7: TODO max31785@52 */
> @@ -704,11 +732,19 @@ static void rainier_bmc_i2c_init(AspeedMachineState *bmc)
> /* Bus 7: TODO si7021-a20@20 */
> i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 7), TYPE_TMP105,
> 0x48);
> + smbus_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 7), 0x50,
> + g_malloc0(64 * 1024));
> + smbus_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 7), 0x51,
> + g_malloc0(64 * 1024));
>
> i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 8), TYPE_TMP105,
> 0x48);
> i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 8), TYPE_TMP105,
> 0x4a);
> + smbus_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 8), 0x50,
> + g_malloc0(64 * 1024));
> + smbus_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 8), 0x51,
> + g_malloc0(64 * 1024));
> i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 8), "pca9552", 0x61);
> /* Bus 8: ucd90320@11 */
> /* Bus 8: ucd90320@b */
> @@ -716,14 +752,34 @@ static void rainier_bmc_i2c_init(AspeedMachineState *bmc)
>
> i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 9), "tmp423", 0x4c);
> i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 9), "tmp423", 0x4d);
> + smbus_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 9), 0x50,
> + g_malloc0(128 * 1024));
>
> i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 10), "tmp423", 0x4c);
> i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 10), "tmp423", 0x4d);
> + smbus_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 10), 0x50,
> + g_malloc0(128 * 1024));
>
> i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 11), TYPE_TMP105,
> 0x48);
> i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 11), TYPE_TMP105,
> 0x49);
> + i2c_mux = i2c_slave_create_simple(aspeed_i2c_get_bus(&soc->i2c, 11),
> + "pca9546", 0x70);
> + smbus_eeprom_init_one(pca954x_i2c_get_bus(i2c_mux, 0), 0x50,
> + g_malloc0(64 * 1024));
> + smbus_eeprom_init_one(pca954x_i2c_get_bus(i2c_mux, 1), 0x51,
> + g_malloc0(64 * 1024));
> +
> +
> + smbus_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 13), 0x50,
> + g_malloc0(64 * 1024));
> +
> + smbus_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 14), 0x50,
> + g_malloc0(64 * 1024));
> +
> + smbus_eeprom_init_one(aspeed_i2c_get_bus(&soc->i2c, 15), 0x50,
> + g_malloc0(64 * 1024));
> }
>
> static bool aspeed_get_mmio_exec(Object *obj, Error **errp)
>
next prev parent reply other threads:[~2021-06-25 8:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 5:06 [PATCH] arm/aspeed: rainier: Add i2c eeproms and muxes Joel Stanley
2021-06-25 8:36 ` Cédric Le Goater [this message]
2021-06-28 4:32 ` Andrew Jeffery
2021-06-28 4:49 ` Joel Stanley
2021-06-28 4:50 ` Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bca2e943-4fa1-ea16-439f-40d8681cfeef@kaod.org \
--to=clg@kaod.org \
--cc=andrew@aj.id.au \
--cc=joel@jms.id.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=venture@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).