From: Richard Henderson <richard.henderson@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] target/i386: fix INSERTQ implementation
Date: Tue, 20 Sep 2022 05:53:35 +0200 [thread overview]
Message-ID: <bca58f9b-13cf-846b-3ec2-8bf2d2832082@linaro.org> (raw)
In-Reply-To: <20220918075609.549781-1-pbonzini@redhat.com>
On 9/18/22 09:56, Paolo Bonzini wrote:
> + else {
> + if (mod != 3) {
> + gen_lea_modrm(env, s, modrm);
> + op2_offset = offsetof(CPUX86State, xmm_t0);
> + gen_ldq_env_A0(s, offsetof(CPUX86State, xmm_t0.ZMM_D(0)));
INSERTQ doesn't support a memory source. The two forms are
INSERTQ xmm1, xmm2, imm8, imm8
INSERTQ xmm1, xmm2
r~
prev parent reply other threads:[~2022-09-20 3:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-18 7:56 [PATCH] target/i386: fix INSERTQ implementation Paolo Bonzini
2022-09-20 3:53 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bca58f9b-13cf-846b-3ec2-8bf2d2832082@linaro.org \
--to=richard.henderson@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).