From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>,
"Peter Maydell" <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [RFC PATCH] qemu-keymap: properly check return from xkb_keymap_mod_get_index
Date: Tue, 20 Jun 2023 17:55:18 +0200 [thread overview]
Message-ID: <bcafa996-128a-d25c-f35a-115b26498710@linaro.org> (raw)
In-Reply-To: <87bkhai1p4.fsf@linaro.org>
On 6/20/23 17:37, Alex Bennée wrote:
> ar maybe? it only got flagged in clang-system once fedora was updated (I
> assume with better sanitizers):
>
> [2773/3696] Generating pc-bios/keymaps/ar with a custom command
> FAILED: pc-bios/keymaps/ar
> /builds/stsquad/qemu/build/qemu-keymap -f pc-bios/keymaps/ar -l ar
> ../qemu-keymap.c:223:16: runtime error: shift exponent 4294967295 is too large for 32-bit type 'int'
> SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../qemu-keymap.c:223:16 in
> [2774/3696] Generating pc-bios/edk2-x86_64-code.fd with a custom command (wrapped by meson to capture output)
> [2775/3696] Generating pc-bios/edk2-x86_64-secure-code.fd with a custom command (wrapped by meson to capture output)
> ninja: build stopped: subcommand failed.
> make: *** [Makefile:153: run-ninja] Error 1
>
> https://gitlab.com/stsquad/qemu/-/jobs/4500683186#L3957
Related:
https://gitlab.com/qemu-project/qemu/-/issues/1709
https://gitlab.com/qemu-project/qemu/-/issues/1712
which note that keymaps/ar has changed to keymaps/ara in xkeyboard-config from 2.38 to 2.39.
r~
next prev parent reply other threads:[~2023-06-20 15:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 15:03 [RFC PATCH] qemu-keymap: properly check return from xkb_keymap_mod_get_index Alex Bennée
2023-06-20 15:16 ` Peter Maydell
2023-06-20 15:37 ` Alex Bennée
2023-06-20 15:42 ` Peter Maydell
2023-06-20 15:55 ` Richard Henderson [this message]
2023-06-20 16:10 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcafa996-128a-d25c-f35a-115b26498710@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).