From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43676) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dwcdr-00076p-5D for qemu-devel@nongnu.org; Mon, 25 Sep 2017 19:18:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dwcdn-0001XO-04 for qemu-devel@nongnu.org; Mon, 25 Sep 2017 19:18:23 -0400 Received: from mail-pg0-x235.google.com ([2607:f8b0:400e:c05::235]:49027) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dwcdm-0001X8-Pt for qemu-devel@nongnu.org; Mon, 25 Sep 2017 19:18:18 -0400 Received: by mail-pg0-x235.google.com with SMTP id v23so4880190pgc.5 for ; Mon, 25 Sep 2017 16:18:18 -0700 (PDT) References: <20170918160012.4317-1-david@redhat.com> <20170918160012.4317-6-david@redhat.com> From: Richard Henderson Message-ID: Date: Mon, 25 Sep 2017 16:18:14 -0700 MIME-Version: 1.0 In-Reply-To: <20170918160012.4317-6-david@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 05/27] s390/tcg: turn INTERRUPT_EXT into a mask List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand , qemu-devel@nongnu.org Cc: thuth@redhat.com, cohuck@redhat.com, borntraeger@de.ibm.com, Alexander Graf , Igor Mammedov , Aurelien Jarno , Matthew Rosato , =?UTF-8?Q?Alex_Benn=c3=a9e?= On 09/18/2017 08:59 AM, David Hildenbrand wrote: > + } else if (env->pending_int | INTERRUPT_EXT_FLOATING) { Surely & here. Otherwise, Reviewed-by: Richard Henderson r~