* [RFC PATCH] hw/mem/Kconfig: NVDIMM device requires CONFIG_MEM_DEVICE
@ 2019-10-15 16:46 Philippe Mathieu-Daudé
2019-10-15 17:07 ` Thomas Huth
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-10-15 16:46 UTC (permalink / raw)
To: qemu-devel
Cc: Thomas Huth, Michael S. Tsirkin, qemu-trivial, Paolo Bonzini,
Igor Mammedov, Philippe Mathieu-Daudé
When selecting only the NVDIMM device with "NVDIMM y", the
device is not compiled/linked because it does not select MEM_DEVICE
and hw/mem/Makefile.objs is not included:
$ git grep mem/ hw/Makefile.objs
hw/Makefile.objs:39:devices-dirs-$(CONFIG_MEM_DEVICE) += mem/
Let NVDIMM config select MEM_DEVICE.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
I'm not sure this is the best fix, maybe we should simply include
mem/ regardless of CONFIG_MEM_DEVICE (all mem devices use it).
---
hw/mem/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/mem/Kconfig b/hw/mem/Kconfig
index 620fd4cb59..5da724d7a2 100644
--- a/hw/mem/Kconfig
+++ b/hw/mem/Kconfig
@@ -7,5 +7,6 @@ config MEM_DEVICE
config NVDIMM
bool
+ select MEM_DEVICE
default y
depends on PC
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [RFC PATCH] hw/mem/Kconfig: NVDIMM device requires CONFIG_MEM_DEVICE
2019-10-15 16:46 [RFC PATCH] hw/mem/Kconfig: NVDIMM device requires CONFIG_MEM_DEVICE Philippe Mathieu-Daudé
@ 2019-10-15 17:07 ` Thomas Huth
2019-10-21 16:31 ` Laurent Vivier
2019-10-21 17:10 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2019-10-15 17:07 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: qemu-trivial, Igor Mammedov, Paolo Bonzini, Michael S. Tsirkin
On 15/10/2019 18.46, Philippe Mathieu-Daudé wrote:
> When selecting only the NVDIMM device with "NVDIMM y", the
> device is not compiled/linked because it does not select MEM_DEVICE
> and hw/mem/Makefile.objs is not included:
>
> $ git grep mem/ hw/Makefile.objs
> hw/Makefile.objs:39:devices-dirs-$(CONFIG_MEM_DEVICE) += mem/
>
> Let NVDIMM config select MEM_DEVICE.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> I'm not sure this is the best fix, maybe we should simply include
> mem/ regardless of CONFIG_MEM_DEVICE (all mem devices use it).
> ---
> hw/mem/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/mem/Kconfig b/hw/mem/Kconfig
> index 620fd4cb59..5da724d7a2 100644
> --- a/hw/mem/Kconfig
> +++ b/hw/mem/Kconfig
> @@ -7,5 +7,6 @@ config MEM_DEVICE
>
> config NVDIMM
> bool
> + select MEM_DEVICE
> default y
> depends on PC
Looks reasonable to me.
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC PATCH] hw/mem/Kconfig: NVDIMM device requires CONFIG_MEM_DEVICE
2019-10-15 16:46 [RFC PATCH] hw/mem/Kconfig: NVDIMM device requires CONFIG_MEM_DEVICE Philippe Mathieu-Daudé
2019-10-15 17:07 ` Thomas Huth
@ 2019-10-21 16:31 ` Laurent Vivier
2019-10-21 17:10 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2019-10-21 16:31 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: qemu-trivial, Paolo Bonzini, Thomas Huth, Igor Mammedov,
Michael S. Tsirkin
Le 15/10/2019 à 18:46, Philippe Mathieu-Daudé a écrit :
> When selecting only the NVDIMM device with "NVDIMM y", the
> device is not compiled/linked because it does not select MEM_DEVICE
> and hw/mem/Makefile.objs is not included:
>
> $ git grep mem/ hw/Makefile.objs
> hw/Makefile.objs:39:devices-dirs-$(CONFIG_MEM_DEVICE) += mem/
>
> Let NVDIMM config select MEM_DEVICE.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> I'm not sure this is the best fix, maybe we should simply include
> mem/ regardless of CONFIG_MEM_DEVICE (all mem devices use it).
> ---
> hw/mem/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/mem/Kconfig b/hw/mem/Kconfig
> index 620fd4cb59..5da724d7a2 100644
> --- a/hw/mem/Kconfig
> +++ b/hw/mem/Kconfig
> @@ -7,5 +7,6 @@ config MEM_DEVICE
>
> config NVDIMM
> bool
> + select MEM_DEVICE
> default y
> depends on PC
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC PATCH] hw/mem/Kconfig: NVDIMM device requires CONFIG_MEM_DEVICE
2019-10-15 16:46 [RFC PATCH] hw/mem/Kconfig: NVDIMM device requires CONFIG_MEM_DEVICE Philippe Mathieu-Daudé
2019-10-15 17:07 ` Thomas Huth
2019-10-21 16:31 ` Laurent Vivier
@ 2019-10-21 17:10 ` Paolo Bonzini
2 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2019-10-21 17:10 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: qemu-trivial, Igor Mammedov, Thomas Huth, Michael S. Tsirkin
On 15/10/19 18:46, Philippe Mathieu-Daudé wrote:
> When selecting only the NVDIMM device with "NVDIMM y", the
> device is not compiled/linked because it does not select MEM_DEVICE
> and hw/mem/Makefile.objs is not included:
>
> $ git grep mem/ hw/Makefile.objs
> hw/Makefile.objs:39:devices-dirs-$(CONFIG_MEM_DEVICE) += mem/
>
> Let NVDIMM config select MEM_DEVICE.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> I'm not sure this is the best fix, maybe we should simply include
> mem/ regardless of CONFIG_MEM_DEVICE (all mem devices use it).
> ---
> hw/mem/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/mem/Kconfig b/hw/mem/Kconfig
> index 620fd4cb59..5da724d7a2 100644
> --- a/hw/mem/Kconfig
> +++ b/hw/mem/Kconfig
> @@ -7,5 +7,6 @@ config MEM_DEVICE
>
> config NVDIMM
> bool
> + select MEM_DEVICE
> default y
> depends on PC
>
Queued, thanks. As a follow-up, hw/mem/memory-device.c can be common-obj-y.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-21 17:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-15 16:46 [RFC PATCH] hw/mem/Kconfig: NVDIMM device requires CONFIG_MEM_DEVICE Philippe Mathieu-Daudé
2019-10-15 17:07 ` Thomas Huth
2019-10-21 16:31 ` Laurent Vivier
2019-10-21 17:10 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).