From: "Liu, Jingqi" <jingqi.liu@intel.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
imammedo@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com,
pbonzini@redhat.com, ehabkost@redhat.com,
richard.henderson@linaro.org
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v2] hw/i386/acpi-build: Get NUMA information from struct NumaState
Date: Tue, 17 Aug 2021 13:39:37 +0800 [thread overview]
Message-ID: <bcc78ee9-3f63-3a58-5f95-9df837dbda38@intel.com> (raw)
In-Reply-To: <447c802d-956d-5cf6-2008-467555590215@redhat.com>
On 8/16/2021 6:05 PM, Philippe Mathieu-Daudé wrote:
> On 8/6/21 5:19 AM, Jingqi Liu wrote:
>
> Maybe prepend with:
>
> Since commits aa57020774b ("numa: move numa global variable
> nb_numa_nodes into MachineState") and 7e721e7b10e ("numa: move
> numa global variable numa_info into MachineState"), we can ...
>
Seems this description is clearer.
I'll add it in next version.
Thanks,
Jingqi
>> We can get NUMA information completely from MachineState::numa_state.
>> Remove PCMachineState::numa_nodes and PCMachineState::node_mem,
>> since they are just copied from MachineState::numa_state.
>>
>> Signed-off-by: Jingqi Liu <jingqi.liu@intel.com>
>> ---
>> hw/i386/acpi-build.c | 12 +++++++-----
>> hw/i386/pc.c | 9 ---------
>> include/hw/i386/pc.h | 4 ----
>> 3 files changed, 7 insertions(+), 18 deletions(-)
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
prev parent reply other threads:[~2021-08-17 5:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 3:19 [PATCH v2] hw/i386/acpi-build: Get NUMA information from struct NumaState Jingqi Liu
2021-08-16 5:57 ` Liu, Jingqi
2021-08-16 10:05 ` Philippe Mathieu-Daudé
2021-08-17 5:39 ` Liu, Jingqi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcc78ee9-3f63-3a58-5f95-9df837dbda38@intel.com \
--to=jingqi.liu@intel.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).