From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Volker Rümelin" <vr_qemu@t-online.de>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/audio/virtio-sound: fix heap buffer overflow
Date: Sat, 7 Sep 2024 07:44:04 +0200 [thread overview]
Message-ID: <bcc9a7e8-6257-47d1-94d6-767ab3f1e786@linaro.org> (raw)
In-Reply-To: <20240901130112.8242-1-vr_qemu@t-online.de>
On 1/9/24 15:01, Volker Rümelin wrote:
> Currently, the guest may write to the device configuration space,
> whereas the virtio sound device specification in chapter 5.14.4
> clearly states that the fields in the device configuration space
> are driver-read-only.
>
> Remove the set_config function from the virtio_snd class.
>
> This also prevents a heap buffer overflow. See QEMU issue #2296.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2296
> Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
> ---
> hw/audio/trace-events | 1 -
> hw/audio/virtio-snd.c | 24 ------------------------
> 2 files changed, 25 deletions(-)
Patch queued, thanks.
prev parent reply other threads:[~2024-09-07 5:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-01 13:01 [PATCH] hw/audio/virtio-sound: fix heap buffer overflow Volker Rümelin
2024-09-02 8:26 ` Gerd Hoffmann
2024-09-07 5:44 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcc9a7e8-6257-47d1-94d6-767ab3f1e786@linaro.org \
--to=philmd@linaro.org \
--cc=kraxel@redhat.com \
--cc=manos.pitsidianakis@linaro.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vr_qemu@t-online.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).