qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] hw/scsi/megasas:Clean up some redundant code fix Clang warnings
@ 2020-03-10 13:08 Chen Qun
  2020-03-10 13:46 ` Peter Maydell
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Chen Qun @ 2020-03-10 13:08 UTC (permalink / raw)
  To: qemu-devel, qemu-trivial
  Cc: Fam Zheng, Hannes Reinecke, zhang.zhanghailiang, qemu-block,
	Euler Robot, Paolo Bonzini, Chen Qun

Here are some redundant statements, we can clean them up.
Clang static code analyzer show warning:
hw/scsi/megasas.c:1175:32: warning: Value stored to 'max_ld_disks' during its initialization is never read
    uint32_t num_ld_disks = 0, max_ld_disks = s->fw_luns;
                               ^~~~~~~~~~~~   ~~~~~~~~~~
hw/scsi/megasas.c:1183:9: warning: Value stored to 'max_ld_disks' is never read
        max_ld_disks = 0;
        ^              ~

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
---
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Fam Zheng <fam@euphon.net>
Cc: Hannes Reinecke <hare@suse.com>
Cc: qemu-block@nongnu.org
---
 hw/scsi/megasas.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
index af18c88b65..3f982e1d3b 100644
--- a/hw/scsi/megasas.c
+++ b/hw/scsi/megasas.c
@@ -1172,7 +1172,7 @@ static int megasas_dcmd_ld_list_query(MegasasState *s, MegasasCmd *cmd)
     uint16_t flags;
     struct mfi_ld_targetid_list info;
     size_t dcmd_size = sizeof(info), resid;
-    uint32_t num_ld_disks = 0, max_ld_disks = s->fw_luns;
+    uint32_t num_ld_disks = 0, max_ld_disks;
     BusChild *kid;
 
     /* mbox0 contains flags */
@@ -1180,7 +1180,6 @@ static int megasas_dcmd_ld_list_query(MegasasState *s, MegasasCmd *cmd)
     trace_megasas_dcmd_ld_list_query(cmd->index, flags);
     if (flags != MR_LD_QUERY_TYPE_ALL &&
         flags != MR_LD_QUERY_TYPE_EXPOSED_TO_HOST) {
-        max_ld_disks = 0;
     }
 
     memset(&info, 0, dcmd_size);
-- 
2.23.0




^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-03-11  6:55 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-10 13:08 [PATCH] hw/scsi/megasas:Clean up some redundant code fix Clang warnings Chen Qun
2020-03-10 13:46 ` Peter Maydell
2020-03-10 15:04   ` Laurent Vivier
2020-03-11  1:10   ` Chenqun (kuhn)
2020-03-10 13:58 ` no-reply
2020-03-10 15:01 ` Laurent Vivier
2020-03-11  6:48   ` Chenqun (kuhn)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).