Re: [Qemu-devel] [PATCH] rename included C files to foo.inc.c, remove osdep.h

[Eric Blake <eblake@redhat.com>]

On 05/04/2018 05:51 AM, Paolo Bonzini wrote:
> osdep.h is only needed for files that are compiled directly.
> Remove it from included C source files, and rename them to
> *.inc.c so that scripts/clean-includes knows to skip them.
> 
> Cc: Eric Blake <eblake@redhat.com>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   target/cris/translate.c                            |    2 +-
>   .../cris/{translate_v10.c => translate_v10.inc.c}  |    0
>   target/mips/translate.c                            |    2 +-
>   .../{translate_init.c => translate_init.inc.c}     |    0
>   target/ppc/int_helper.c                            |    2 +-
>   target/ppc/{mfrom_table.c => mfrom_table.inc.c}    |    0
>   target/ppc/translate.c                             |    2 +-
>   .../ppc/{translate_init.c => translate_init.inc.c} |    1 -
>   ui/vnc-enc-zrle.c                                  |   22 ++++++++++----------
>   ui/{vnc-enc-zrle-template.c => vnc-enc-zrle.inc.c} |    0
>   10 files changed, 15 insertions(+), 16 deletions(-)
>   rename target/cris/{translate_v10.c => translate_v10.inc.c} (100%)
>   rename target/mips/{translate_init.c => translate_init.inc.c} (100%)
>   rename target/ppc/{mfrom_table.c => mfrom_table.inc.c} (100%)
>   rename target/ppc/{translate_init.c => translate_init.inc.c} (99%)
>   rename ui/{vnc-enc-zrle-template.c => vnc-enc-zrle.inc.c} (100%)

How did we ever manage rename patches without git's nice compressed 
patch representation? :)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org