qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Warner Losh <imp@bsdimp.com>, Kyle Evans <kevans@freebsd.org>,
	libvir-list@redhat.com, Markus Armbruster <armbru@redhat.com>,
	Laurent Vivier <laurent@vivier.eu>,
	Eric Blake <eblake@redhat.com>
Subject: Re: [PATCH v3 07/10] accel/tcg: Report one-insn-per-tb in 'info jit',  not 'info status'
Date: Tue, 18 Apr 2023 10:06:33 +0200	[thread overview]
Message-ID: <bcd87bea-110a-81aa-70a8-b65fc19b3aab@linaro.org> (raw)
In-Reply-To: <20230417164041.684562-8-peter.maydell@linaro.org>

On 4/17/23 18:40, Peter Maydell wrote:
> Currently we report whether the TCG accelerator is in
> 'one-insn-per-tb' mode in the 'info status' output.  This is a pretty
> minor piece of TCG specific information, and we want to deprecate the
> 'singlestep' field of the associated QMP command.  Move the
> 'one-insn-per-tb' reporting to 'info jit'.
> 
> We don't need a deprecate-and-drop period for this because the
> HMP interface has no stability guarantees.
> 
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
> The new 'accelerator settings' subsection of the output
> currently only has one item, but it would be a place to put
> other stuff, eg if we wanted to mention whether split-wx is
> enabled.
> ---
>   accel/tcg/monitor.c         | 14 ++++++++++++++
>   softmmu/runstate-hmp-cmds.c |  5 ++---
>   2 files changed, 16 insertions(+), 3 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


  reply	other threads:[~2023-04-18  8:06 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-17 16:40 [PATCH v3 00/10] Deprecate/rename singlestep command line option, monitor interfaces Peter Maydell
2023-04-17 16:40 ` [PATCH v3 01/10] make one-insn-per-tb an accel option Peter Maydell
2023-04-17 16:40 ` [PATCH v3 02/10] softmmu: Don't use 'singlestep' global in QMP and HMP commands Peter Maydell
2023-04-20  8:54   ` Philippe Mathieu-Daudé
2023-04-17 16:40 ` [PATCH v3 03/10] accel/tcg: Use one_insn_per_tb global instead of old singlestep global Peter Maydell
2023-04-18  8:02   ` Richard Henderson
2023-04-18  8:05   ` Richard Henderson
2023-04-18  9:44     ` Peter Maydell
2023-04-20  8:55   ` Philippe Mathieu-Daudé
2023-04-17 16:40 ` [PATCH v3 04/10] linux-user: Add '-one-insn-per-tb' option equivalent to '-singlestep' Peter Maydell
2023-04-20  9:13   ` Philippe Mathieu-Daudé
2023-04-20  9:19     ` Peter Maydell
2023-04-20 10:05       ` Philippe Mathieu-Daudé
2023-04-17 16:40 ` [PATCH v3 05/10] bsd-user: " Peter Maydell
2023-04-20  9:13   ` Philippe Mathieu-Daudé
2023-04-17 16:40 ` [PATCH v3 06/10] Document that -singlestep command line option is deprecated Peter Maydell
2023-04-20  8:56   ` Philippe Mathieu-Daudé
2023-04-17 16:40 ` [PATCH v3 07/10] accel/tcg: Report one-insn-per-tb in 'info jit', not 'info status' Peter Maydell
2023-04-18  8:06   ` Richard Henderson [this message]
2023-04-20  9:02   ` Philippe Mathieu-Daudé
2023-04-17 16:40 ` [PATCH v3 08/10] hmp: Add 'one-insn-per-tb' command equivalent to 'singlestep' Peter Maydell
2023-04-20  9:03   ` Philippe Mathieu-Daudé
2023-04-17 16:40 ` [PATCH v3 09/10] qapi/run-state.json: Fix missing newline at end of file Peter Maydell
2023-04-20  9:04   ` Philippe Mathieu-Daudé
2023-04-17 16:40 ` [PATCH v3 10/10] hmp: Deprecate 'singlestep' member of StatusInfo Peter Maydell
2023-04-18  8:08   ` Richard Henderson
2023-04-20  9:05   ` Philippe Mathieu-Daudé
2023-04-24 10:06   ` Peter Maydell
     [not found]   ` <87jzy18oqv.fsf@pond.sub.org>
2023-04-25 12:13     ` Peter Maydell
2023-04-25 13:08       ` Markus Armbruster
2023-05-02 10:22 ` [PATCH v3 00/10] Deprecate/rename singlestep command line option, monitor interfaces Peter Maydell
2023-05-02 10:43   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bcd87bea-110a-81aa-70a8-b65fc19b3aab@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=imp@bsdimp.com \
    --cc=kevans@freebsd.org \
    --cc=laurent@vivier.eu \
    --cc=libvir-list@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).