From: Thomas Huth <thuth@redhat.com>
To: Peter Xu <peterx@redhat.com>, qemu-devel@nongnu.org
Cc: Leonardo Bras Soares Passos <lsoaresp@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [PATCH] tests: migration-test: Allow test to run without uffd
Date: Mon, 18 Jul 2022 20:23:26 +0200 [thread overview]
Message-ID: <bcd9b961-d1b5-e334-5bb1-7ee56be29725@redhat.com> (raw)
In-Reply-To: <20220707184600.24164-1-peterx@redhat.com>
On 07/07/2022 20.46, Peter Xu wrote:
> We used to stop running all tests if uffd is not detected. However
> logically that's only needed for postcopy not the rest of tests.
>
> Keep running the rest when still possible.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> tests/qtest/migration-test.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
Did you test your patch in the gitlab-CI? I just added it to my testing-next
branch and the the test is failing reproducibly on macOS here:
https://gitlab.com/thuth/qemu/-/jobs/2736260861#L6275
https://gitlab.com/thuth/qemu/-/jobs/2736623914#L6275
(without your patch the whole test is skipped instead)
Thomas
next prev parent reply other threads:[~2022-07-18 18:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 18:46 [PATCH] tests: migration-test: Allow test to run without uffd Peter Xu
2022-07-08 9:57 ` Daniel P. Berrangé
2022-07-18 18:23 ` Thomas Huth [this message]
2022-07-18 19:14 ` Peter Xu
2022-07-19 8:32 ` Daniel P. Berrangé
2022-07-19 10:28 ` Thomas Huth
2022-07-19 10:37 ` Daniel P. Berrangé
2022-07-19 19:53 ` Peter Xu
2022-07-20 10:52 ` Thomas Huth
2022-07-20 12:55 ` Peter Xu
2022-07-20 14:11 ` Thomas Huth
2022-07-20 14:32 ` Daniel P. Berrangé
2022-07-21 18:24 ` Peter Xu
2022-07-22 8:14 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcd9b961-d1b5-e334-5bb1-7ee56be29725@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lsoaresp@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).