From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, kwolf@redhat.omc
Subject: Re: [PATCH 3/5] block: reduce files included by block/aio.h
Date: Thu, 4 Dec 2025 18:46:28 +0100 [thread overview]
Message-ID: <bce5cda9-ff60-4e1f-bad8-862063831123@redhat.com> (raw)
In-Reply-To: <38f73101-4f2d-4e62-8ea3-fc42cc90e8f3@linaro.org>
On 12/4/25 18:03, Philippe Mathieu-Daudé wrote:
>>>> QEMUBH *aio_bh_new_full(AioContext *ctx, QEMUBHFunc *cb, void
>>>> *opaque,
>>>> - const char *name, MemReentrancyGuard
>>>> *reentrancy_guard);
>>>> + const char *name, struct MemReentrancyGuard
>>>> *reentrancy_guard);
>>>
>>> I suppose these changes were before you move the declarations to their
>>> own "qemu/mem-reentrancy.h" header?
>>
>> Yes, but also qemu/mem-reentrancy.h is not included here.
>
> We want to also include it instead, right? (No need to forward declare)
Why? The struct is opaque, and as a general principle avoiding
header-from-header inclusions reduces compile times.
Paolo
next prev parent reply other threads:[~2025-12-04 17:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 18:51 [PATCH 0/5] block: move AioContext and AIOCB out of include/block/ Paolo Bonzini
2025-12-03 18:51 ` [PATCH 1/5] hw: add missing includes hidden by block/aio.h Paolo Bonzini
2025-12-04 8:32 ` Philippe Mathieu-Daudé
2025-12-03 18:51 ` [PATCH 2/5] block: extract include/qemu/aiocb.h out of include/block/aio.h Paolo Bonzini
2025-12-04 8:33 ` Philippe Mathieu-Daudé
2025-12-03 18:51 ` [PATCH 3/5] block: reduce files included by block/aio.h Paolo Bonzini
2025-12-04 8:35 ` Philippe Mathieu-Daudé
2025-12-04 9:25 ` Paolo Bonzini
2025-12-04 17:03 ` Philippe Mathieu-Daudé
2025-12-04 17:46 ` Paolo Bonzini [this message]
2025-12-03 18:51 ` [PATCH 4/5] block: rename block/aio.h to qemu/aio.h Paolo Bonzini
2025-12-04 8:35 ` Philippe Mathieu-Daudé
2025-12-03 18:51 ` [PATCH 5/5] block: rename block/aio-wait.h to qemu/aio-wait.h Paolo Bonzini
2025-12-04 8:36 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bce5cda9-ff60-4e1f-bad8-862063831123@redhat.com \
--to=pbonzini@redhat.com \
--cc=kwolf@redhat.omc \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).