From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:50952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gvQeg-0005Zp-Do for qemu-devel@nongnu.org; Sun, 17 Feb 2019 12:55:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gvQef-0000I7-OE for qemu-devel@nongnu.org; Sun, 17 Feb 2019 12:55:06 -0500 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]:38676) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gvQef-0000H8-Fu for qemu-devel@nongnu.org; Sun, 17 Feb 2019 12:55:05 -0500 Received: by mail-pl1-x643.google.com with SMTP id e5so7551730plb.5 for ; Sun, 17 Feb 2019 09:55:05 -0800 (PST) References: <20190214125107.22178-1-peter.maydell@linaro.org> <20190214125107.22178-4-peter.maydell@linaro.org> From: Richard Henderson Message-ID: Date: Sun, 17 Feb 2019 09:55:00 -0800 MIME-Version: 1.0 In-Reply-To: <20190214125107.22178-4-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 03/14] hw/timer/pl031: Allow use as an embedded-struct device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: patches@linaro.org On 2/14/19 4:50 AM, Peter Maydell wrote: > Create a new include file for the pl031's device struct, > type macros, etc, so that it can be instantiated using > the "embedded struct" coding style. > > Signed-off-by: Peter Maydell > --- > include/hw/timer/pl031.h | 44 ++++++++++++++++++++++++++++++++++++++++ > hw/timer/pl031.c | 25 +---------------------- > MAINTAINERS | 1 + > 3 files changed, 46 insertions(+), 24 deletions(-) > create mode 100644 include/hw/timer/pl031.h Reviewed-by: Richard Henderson r~