From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Pierrick Bouvier <pierrick.bouvier@linaro.org>, qemu-devel@nongnu.org
Cc: sw@weilnetz.de, kkostiuk@redhat.com, clg@kaod.org,
richard.henderson@linaro.org, alex.bennee@linaro.org,
peter.maydell@linaro.org
Subject: Re: [PATCH v3 0/4] Adds support for running QEMU natively on windows-arm64
Date: Mon, 20 Feb 2023 12:33:04 +0100 [thread overview]
Message-ID: <bcf0b85d-edbf-335f-ac74-c27a4cecdcb8@linaro.org> (raw)
In-Reply-To: <20230220111215.27471-1-pierrick.bouvier@linaro.org>
Hi Pierrick,
On 20/2/23 12:12, Pierrick Bouvier wrote:
> Since v2:
>
> - Delete superfluous comment on unreachable code
> - Fix style for multiline comments
>
> Since v1:
>
> - Comment why we use generic version of flush_idcache_range
> - Ensure __mingw_setjmp/longjmp are available using meson
> - Fix a warning by calling g_assert_not_reached() instead of initializing a
> variable
>
> As before this was tested with:
> - make check
> - boot an x64 debian bullseye vm
> - boot an arm64 ubuntu 22.10 vm
>
> Thanks
>
> Pierrick Bouvier (4):
> util/cacheflush: fix cache on windows-arm64
> sysemu/os-win32: fix setjmp/longjmp on windows-arm64
> qga/vss-win32: fix warning for clang++-15
> target/ppc: fix warning with clang-15
You forgot to include the 'Reviewed-by/Acked-by' tags from your previous
versions. See from these guidelines:
https://www.qemu.org/docs/master/devel/submitting-a-patch.html#proper-use-of-reviewed-by-tags-can-aid-review
When reviewing a large series, a reviewer can reply to some of the
patches with a Reviewed-by tag, stating that they are happy with
that patch in isolation [...]. You should then update those commit
messages by hand to include the Reviewed-by tag, so that in the next
revision, reviewers can spot which patches were already clean from
the previous round.
No need for a v4, you can reply to each patch with the missed tags.
next prev parent reply other threads:[~2023-02-20 11:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 11:12 [PATCH v3 0/4] Adds support for running QEMU natively on windows-arm64 Pierrick Bouvier
2023-02-20 11:12 ` [PATCH v3 1/4] util/cacheflush: fix cache " Pierrick Bouvier
2023-02-20 15:16 ` Pierrick Bouvier
2023-02-20 11:12 ` [PATCH v3 2/4] sysemu/os-win32: fix setjmp/longjmp " Pierrick Bouvier
2023-02-20 15:16 ` Pierrick Bouvier
2023-02-21 9:47 ` Pierrick Bouvier
2023-02-21 10:33 ` Philippe Mathieu-Daudé
2023-02-21 13:16 ` Pierrick Bouvier
2023-02-21 14:27 ` Philippe Mathieu-Daudé
2023-02-20 11:12 ` [PATCH v3 3/4] qga/vss-win32: fix warning for clang++-15 Pierrick Bouvier
2023-02-20 15:16 ` Pierrick Bouvier
2023-02-21 10:24 ` Philippe Mathieu-Daudé
2023-02-20 11:12 ` [PATCH v3 4/4] target/ppc: fix warning with clang-15 Pierrick Bouvier
2023-02-20 15:16 ` Pierrick Bouvier
2023-02-20 11:33 ` Philippe Mathieu-Daudé [this message]
2023-02-20 15:10 ` [PATCH v3 0/4] Adds support for running QEMU natively on windows-arm64 Pierrick Bouvier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcf0b85d-edbf-335f-ac74-c27a4cecdcb8@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=clg@kaod.org \
--cc=kkostiuk@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).