Re: [Qemu-devel] [PATCH] tests/bios-tables-test: Sanitize test verbose output

[Eric Blake <eblake@redhat.com>]

On 10/29/18 7:18 PM, Philippe Mathieu-Daudé wrote:
> Fix the extraneous extra blank lines in the test output when running with V=1.
> 

> +++ b/tests/bios-tables-test.c
> @@ -371,6 +371,9 @@ static GArray *load_expected_aml(test_data *data)
>       gboolean ret;
>   
>       GArray *exp_tables = g_array_new(false, true, sizeof(AcpiSdtTable));
> +    if (getenv("V")) {
> +        fputc('\n', stderr);
> +    }

Umm, this prints a blank line even if I run 'make check V=0' - do we 
support V=0 as a way to disable verbosity, in which case you need to 
actually inspect the contents of $V rather than just assuming that if it 
is in the environment things are verbose?

> @@ -397,7 +400,7 @@ try_again:
>           }
>           g_assert(exp_sdt.aml_file);
>           if (getenv("V")) {
> -            fprintf(stderr, "\nUsing expected file '%s'\n", aml_file);
> +            fprintf(stderr, "Using expected file '%s'\n", aml_file);

But that's a pre-existing question, so it doesn't affect this particular 
patch.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org