From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org, Jason Wang <jasowang@redhat.com>,
Anthony Liguori <anthony@codemonkey.ws>,
stefanha@linux.vnet.ibm.com, aurelien@aurel32.net
Subject: [Qemu-devel] [PATCHv2 07/14] virtio-net: first s/g is always at start of buf
Date: Tue, 25 Sep 2012 13:12:31 +0200 [thread overview]
Message-ID: <bd012b98905ceaf18f54b033d1cc618a242bd348.1348571185.git.mst@redhat.com> (raw)
In-Reply-To: <cover.1348571185.git.mst@redhat.com>
We know offset is 0, assert that.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/virtio-net.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/virtio-net.c b/hw/virtio-net.c
index fde2322..b9a8be4 100644
--- a/hw/virtio-net.c
+++ b/hw/virtio-net.c
@@ -631,6 +631,7 @@ static ssize_t virtio_net_receive(NetClientState *nc, const uint8_t *buf, size_t
}
if (i == 0) {
+ assert(offset == 0);
if (n->mergeable_rx_bufs) {
mhdr_cnt = iov_copy(mhdr_sg, ARRAY_SIZE(mhdr_sg),
sg, elem.in_num,
@@ -638,8 +639,8 @@ static ssize_t virtio_net_receive(NetClientState *nc, const uint8_t *buf, size_t
sizeof(mhdr.num_buffers));
}
- receive_header(n, sg, elem.in_num, buf + offset, size - offset);
- offset += n->host_hdr_len;
+ receive_header(n, sg, elem.in_num, buf, size);
+ offset = n->host_hdr_len;
total += n->guest_hdr_len;
guest_offset = n->guest_hdr_len;
} else {
--
MST
next prev parent reply other threads:[~2012-09-25 11:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 11:12 [Qemu-devel] [PATCHv2 00/14] virtio-net: iovec handling cleanup Michael S. Tsirkin
2012-09-25 11:12 ` [Qemu-devel] [PATCHv2 01/14] virtio-net: track host/guest header length Michael S. Tsirkin
2012-09-25 11:12 ` [Qemu-devel] [PATCHv2 02/14] iov: add const annotation Michael S. Tsirkin
2012-09-25 11:12 ` [Qemu-devel] [PATCHv2 03/14] iov: add iov_cpy Michael S. Tsirkin
2012-09-25 11:12 ` [Qemu-devel] [PATCHv2 04/14] virtio-net: avoid sg copy Michael S. Tsirkin
2012-09-25 11:12 ` [Qemu-devel] [PATCHv2 05/14] virtio-net: use safe iov operations for rx Michael S. Tsirkin
2012-09-25 11:12 ` [Qemu-devel] [PATCHv2 06/14] virtio-net: refactor receive_hdr Michael S. Tsirkin
2012-09-25 11:12 ` Michael S. Tsirkin [this message]
2012-09-25 11:12 ` [Qemu-devel] [PATCHv2 08/14] virtio-net: switch tx to safe iov functions Michael S. Tsirkin
2012-09-25 11:12 ` [Qemu-devel] [PATCHv2 09/14] virtio-net: simplify rx code Michael S. Tsirkin
2012-09-25 11:12 ` [Qemu-devel] [PATCHv2 10/14] virtio: don't mark unaccessed memory as dirty Michael S. Tsirkin
2012-09-25 11:12 ` [Qemu-devel] [PATCHv2 11/14] virtio-net: fix used len for tx Michael S. Tsirkin
2012-09-25 11:12 ` [Qemu-devel] [PATCHv2 12/14] virtio-net: minor code simplification Michael S. Tsirkin
2012-09-25 11:12 ` [Qemu-devel] [PATCHv2 13/14] virtio-net: test peer header support at init time Michael S. Tsirkin
2012-09-25 11:13 ` [Qemu-devel] [PATCHv2 14/14] virtio-net: enable mrg buf header in tap on linux Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd012b98905ceaf18f54b033d1cc618a242bd348.1348571185.git.mst@redhat.com \
--to=mst@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=aurelien@aurel32.net \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).