From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>
Cc: Felipe Franciosi <felipe@nutanix.com>,
Pavel Dovgalyuk <dovgaluk@ispras.ru>,
qemu-devel <qemu-devel@nongnu.org>,
Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
Subject: Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result
Date: Wed, 21 Sep 2016 13:18:58 -0500 [thread overview]
Message-ID: <bd059b3e-bb2f-fd15-a7cb-588f075bdab9@redhat.com> (raw)
In-Reply-To: <87zin1w9v4.fsf@dusky.pond.sub.org>
[-- Attachment #1: Type: text/plain, Size: 1056 bytes --]
On 09/21/2016 10:28 AM, Markus Armbruster wrote:
>> The compiler.h file has no license header, just a comment
>> saying "public domain", which is obviously not the case
>> if you add this macro.
>>
>> Given that you'll need to explicitly mention the license terms
>> for ignore_value. eg with a comment line like
>>
>> /* The ignore_value() macro is taken from GNULIB ignore-value.h,
>> * licensed under the terms of the LGPLv2+
>> */
>
> Our tree has a mix of licenses, which is enough of a pain. Mixing
> licenses within *files* is even worse, and might not even be legally
> sound.
>
> Relicense the whole file under our preferred license GPLv2+?
That works too. No one can legally complain - the current license is so
permissive that marking the entire file LGPLv2+ is permitted by the
current license. It's a one-way conversion (we can't go back once we do
it), but I would be fine with that approach.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-09-21 18:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 17:08 [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result Felipe Franciosi
2016-09-21 5:17 ` Pavel Dovgalyuk
2016-09-21 6:24 ` Markus Armbruster
2016-09-21 10:00 ` Felipe Franciosi
2016-09-21 10:03 ` Pavel Dovgalyuk
2016-09-21 10:07 ` Daniel P. Berrange
2016-09-21 10:12 ` Felipe Franciosi
2016-09-21 12:28 ` Felipe Franciosi
2016-09-21 12:31 ` Markus Armbruster
2016-09-21 13:55 ` Eric Blake
2016-09-21 14:26 ` Felipe Franciosi
2016-09-21 14:35 ` Daniel P. Berrange
2016-09-21 14:38 ` Felipe Franciosi
2016-09-21 14:44 ` Eric Blake
2016-09-21 15:28 ` Markus Armbruster
2016-09-21 18:18 ` Eric Blake [this message]
2016-09-22 8:00 ` Daniel P. Berrange
2016-09-22 11:51 ` Markus Armbruster
2016-09-22 13:30 ` Eric Blake
2016-09-23 8:15 ` Markus Armbruster
2016-09-23 13:02 ` Felipe Franciosi
2016-09-21 14:42 ` Eric Blake
2016-09-21 9:17 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd059b3e-bb2f-fd15-a7cb-588f075bdab9@redhat.com \
--to=eblake@redhat.com \
--cc=Pavel.Dovgaluk@ispras.ru \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dovgaluk@ispras.ru \
--cc=felipe@nutanix.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).