From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60808) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmm6r-0001rl-EY for qemu-devel@nongnu.org; Wed, 21 Sep 2016 14:19:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmm6m-0003EX-Fz for qemu-devel@nongnu.org; Wed, 21 Sep 2016 14:19:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44052) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmm6m-0003EH-61 for qemu-devel@nongnu.org; Wed, 21 Sep 2016 14:19:00 -0400 References: <1474391326-871-1-git-send-email-felipe@nutanix.com> <000301d213c7$7142f980$53c8ec80$@ru> <87y42l93dr.fsf@dusky.pond.sub.org> <20160921100718.GO15535@redhat.com> <87mvj11ljr.fsf@dusky.pond.sub.org> <7500849B-8BCC-4743-92A6-5DBD4D8575E8@nutanix.com> <20160921143546.GS15535@redhat.com> <87zin1w9v4.fsf@dusky.pond.sub.org> From: Eric Blake Message-ID: Date: Wed, 21 Sep 2016 13:18:58 -0500 MIME-Version: 1.0 In-Reply-To: <87zin1w9v4.fsf@dusky.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nuocgclrNokkCRBUC1qmbDaT5rjuGvPEg" Subject: Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , "Daniel P. Berrange" Cc: Felipe Franciosi , Pavel Dovgalyuk , qemu-devel , Pavel Dovgalyuk This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nuocgclrNokkCRBUC1qmbDaT5rjuGvPEg From: Eric Blake To: Markus Armbruster , "Daniel P. Berrange" Cc: Felipe Franciosi , Pavel Dovgalyuk , qemu-devel , Pavel Dovgalyuk Message-ID: Subject: Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result References: <1474391326-871-1-git-send-email-felipe@nutanix.com> <000301d213c7$7142f980$53c8ec80$@ru> <87y42l93dr.fsf@dusky.pond.sub.org> <20160921100718.GO15535@redhat.com> <87mvj11ljr.fsf@dusky.pond.sub.org> <7500849B-8BCC-4743-92A6-5DBD4D8575E8@nutanix.com> <20160921143546.GS15535@redhat.com> <87zin1w9v4.fsf@dusky.pond.sub.org> In-Reply-To: <87zin1w9v4.fsf@dusky.pond.sub.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/21/2016 10:28 AM, Markus Armbruster wrote: >> The compiler.h file has no license header, just a comment >> saying "public domain", which is obviously not the case >> if you add this macro. >> >> Given that you'll need to explicitly mention the license terms >> for ignore_value. eg with a comment line like >> >> /* The ignore_value() macro is taken from GNULIB ignore-value.h, >> * licensed under the terms of the LGPLv2+ >> */ >=20 > Our tree has a mix of licenses, which is enough of a pain. Mixing > licenses within *files* is even worse, and might not even be legally > sound. >=20 > Relicense the whole file under our preferred license GPLv2+? That works too. No one can legally complain - the current license is so permissive that marking the entire file LGPLv2+ is permitted by the current license. It's a one-way conversion (we can't go back once we do it), but I would be fine with that approach. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --nuocgclrNokkCRBUC1qmbDaT5rjuGvPEg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX4s8SAAoJEKeha0olJ0NqoYkH/iUwTpsBPlZfTFoqtfV9Mjck kUyl0lh/PbGQFxFgFGENznagu4F47zX0WQ/QkptunqFuYMQ4D+DlOLpL5zi4IVjG SbYutsWvNsdDIT76Vhj1voq7kIgC1jfZonvQdqmlgdWPKbH5JPnGncvDAQxaaaR0 wbgXhITjoWwNoUIGqnZWXQpE0kuvGGt7nHbKfT/vctqgVpBassJkYQLyQzEV28Ct S3A8TNaYso2tJ2G4ubKAXHms/lmR9NAfZkzTQ7+bItSKsfVgFt2OJZMLbwxJonOp lKo9OQ5G6nPhveDcqBTNnJ4nbHDggoNvuTTmYJJuU640GmgdaCkVjYPggzPlE/M= =iR0t -----END PGP SIGNATURE----- --nuocgclrNokkCRBUC1qmbDaT5rjuGvPEg--