From: Richard Henderson <richard.henderson@linaro.org>
To: Douglas Crosher <dtc-ubuntu@scieneer.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, rth@twiddle.net
Subject: Re: [PATCH] cpu_exec_step_atomic: update the cpu running flag
Date: Fri, 15 Jan 2021 13:05:32 -1000 [thread overview]
Message-ID: <bd0d8648-d270-2b59-41fb-94f9cbcb228d@linaro.org> (raw)
In-Reply-To: <a272c656-f7c5-019d-1cc0-499b8f80f2fc@scieneer.com>
On 9/21/20 9:42 PM, Douglas Crosher wrote:
>
> The cpu_exec_step_atomic() function is called with the cpu->running
> clear and proceeds to run target code without setting this flag. If
> this target code generates an exception then handle_cpu_signal() will
> unnecessarily abort.
>
> For example if atomic code generates a memory protection fault.
>
> This patch at least sets and clears this running flag.
>
> The related code paths look rather convoluted and it is not immediately clear
> that this patch comprehensively addresses the issue, but it might at least
> direct people to a problem, and it might be an incremental improvement, and it
> gets some code running here. The patch adds some assertions to help detect
> other cases.
>
> Signed-off-by: Douglas Crosher <dtc-ubuntu@scieneer.com>
Sorry this got overlooked, but better late than never.
Yes, this looks right, thanks.
Queued to tcg-next.
r~
prev parent reply other threads:[~2021-01-15 23:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 7:42 [PATCH] cpu_exec_step_atomic: update the cpu running flag Douglas Crosher
2021-01-15 23:05 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd0d8648-d270-2b59-41fb-94f9cbcb228d@linaro.org \
--to=richard.henderson@linaro.org \
--cc=dtc-ubuntu@scieneer.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).