From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58807) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b31us-00021V-B6 for qemu-devel@nongnu.org; Wed, 18 May 2016 09:53:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b31um-0003my-7r for qemu-devel@nongnu.org; Wed, 18 May 2016 09:53:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50761) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b31um-0003mX-28 for qemu-devel@nongnu.org; Wed, 18 May 2016 09:53:32 -0400 References: <1463412982-6681-1-git-send-email-pbonzini@redhat.com> <20160518102147.30c63802.cornelia.huck@de.ibm.com> <20160518105952.3cd61418.cornelia.huck@de.ibm.com> <6c4b2f9a-ef49-2a56-817f-9b62f4b2b6ed@redhat.com> <20160518154605.3e5282c3.cornelia.huck@de.ibm.com> From: Paolo Bonzini Message-ID: Date: Wed, 18 May 2016 15:53:23 +0200 MIME-Version: 1.0 In-Reply-To: <20160518154605.3e5282c3.cornelia.huck@de.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH CFT v3 00/50] NEED_CPU_H / cpu.h / hw/hw.h cleanups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: qemu-devel@nongnu.org, Thomas Huth On 18/05/2016 15:46, Cornelia Huck wrote: > On Wed, 18 May 2016 13:11:08 +0200 > Paolo Bonzini wrote: > >> On 18/05/2016 10:59, Cornelia Huck wrote: >>>> That's on one of my s390x systems; on another one (where I don't test), >>>> it builds. But something's wrong :) >>> >>> Ah, that's because the functioning one used --disable-kvm. >>> >>> Should the call to kvm_check_extension() be moved to target-s390x/kvm.c? >> >> It can also be moved to machine.c too... > > Your current branch now works fine. > >> Since I don't know exactly >> which patch causes it, I can put this at the beginning: >> >> From 2f86d8c15e0b0514116d36727ecaf3f479f2af33 Mon Sep 17 00:00:00 2001 >> From: Paolo Bonzini >> Date: Wed, 18 May 2016 13:08:02 +0200 >> Subject: [PATCH] s390x: move vregs_needed to machine.c >> >> It is only needed in one file, move it there. >> >> Signed-off-by: Paolo Bonzini >> --- >> target-s390x/cpu.h | 15 --------------- >> target-s390x/machine.c | 10 ++++++++++ >> 2 files changed, 10 insertions(+), 15 deletions(-) > > Acked-by: Cornelia Huck > > Should I look at the other patches touching s390x as well, or will you > resend? They are untouched, so you can look at this version. s390x was really the only part where I had remarks from the maintainers, so you shouldn't have surprises. :) Paolo