From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F8A0C433EF for ; Mon, 20 Sep 2021 18:44:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 92F16606A5 for ; Mon, 20 Sep 2021 18:44:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 92F16606A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:35054 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSOHS-0000NJ-He for qemu-devel@archiver.kernel.org; Mon, 20 Sep 2021 14:44:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35662) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSOG3-000832-Mr for qemu-devel@nongnu.org; Mon, 20 Sep 2021 14:43:16 -0400 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]:55058) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mSOG2-0002sK-7E for qemu-devel@nongnu.org; Mon, 20 Sep 2021 14:43:15 -0400 Received: by mail-pj1-x1034.google.com with SMTP id me1so4005195pjb.4 for ; Mon, 20 Sep 2021 11:43:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:from:to:references:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=fSo+DtTHgSf5viZ+pURPbIggvwhSNGl9nQmCZWqKW1E=; b=qHg+umX7nh8ItpE8CqaFayCUDeUm1B++/pmupDOYg67vMayrItijaQxwr0zajzwMIm zZDsmaOkKPtbqJecu5XN0lV38Iqh7R334YyeDKYCognrp8lIFNmTdTljBbh0P4jApFxT N9jWspK+zRvlkU30LpKtoM1kfR8VDEqFXYy0M9V1AcuClw4GHVc+E6zZfeedKgNZkGef p2C3E6Lg0nVnzmFVMLOJW5lcG3nT4LiLL3+m7psp84hCDe9pypKrs2O59WkC4SFF98QD MYPkmto3qrNhDzO14KEQINfrU9h3FAuFBoSHe6OJAJX2IpKaPA8lgDbVZ2YRWdLb5Lvh +yxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fSo+DtTHgSf5viZ+pURPbIggvwhSNGl9nQmCZWqKW1E=; b=5bd0SIwxIXchCtk8UOdYrQzRsfkRl2QNjAbVLrAVZxNohrc6N43+d3nVHDBSGXne3h /CNj1oq9EjoYca4LZpTNVt8fS4/GPSIIWSGCVJWPFTKKRRdebqVGk9okWnWoKhe6IiiN GFkCG+iPSNJSB93oY2MlxTOBUxUlAZ8KGiBUzswQCnHZIBuJ5POqyYDwQrizY4IwQyvd YkYAIdzmxqRHNLEkQf/lNfW1lqiKnYrNLNa/XXSodiJJM/ox4Pt756llascy0twap1UZ DBiBZmlmrD+ErGkdMVPGqPIygO7wLAqv6pv2T4ark2o3dxd/wCQJ0H6DsIPXcyZZ6uuM ogcg== X-Gm-Message-State: AOAM531NDbUu+fRLKyT8DFiq+K+mHixJhY5zOU4N0g0x+Y3TjB0T9hOH qn9xGXmlvDqPpWssME57tknb0rr81+dLlA== X-Google-Smtp-Source: ABdhPJycN2gfyHvHak+CWhdO86q2KjBjy3yh00stHcrjcnjECv6AIhf/K5f61ppWi1Ys072RGsvbog== X-Received: by 2002:a17:90a:192:: with SMTP id 18mr485510pjc.119.1632163391687; Mon, 20 Sep 2021 11:43:11 -0700 (PDT) Received: from [192.168.1.11] ([71.212.134.125]) by smtp.gmail.com with ESMTPSA id bx2sm166581pjb.35.2021.09.20.11.43.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 11:43:11 -0700 (PDT) Subject: Re: tcg: pointer size warning on x32 arch From: Richard Henderson To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Michael Tokarev , qemu-devel@nongnu.org References: <6b1c1c7f-0e0b-fd49-2ef8-1ab7c8b7a3e5@amsat.org> Message-ID: Date: Mon, 20 Sep 2021 11:43:09 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1034; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1034.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/12/21 6:10 AM, Richard Henderson wrote: > We may need something like > >     if (sizeof(void *) == 8) { >         diff = tcg_pcrel_diff(s, (const void *)(uintptr_t)arg) - 7; >         ... >     } > > I wonder if I still have an x32 vmm hanging about. I do not have an x32 vmm anymore, and I don't see a distro ships one either. So: Michael, are you able to test and submit a patch? Otherwise, because of the lack of distro thing, I'm tempted to drop x32 support entirely. r~