qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: "Daniel P . Berrange" <berrange@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Cleber Rosa" <crosa@redhat.com>
Subject: Re: [PATCH v3 01/11] gitlab-ci: Drop generic cache rule
Date: Mon, 9 Nov 2020 10:46:31 +0100	[thread overview]
Message-ID: <bd24518d-0ffa-8951-159a-3d0d810d06db@redhat.com> (raw)
In-Reply-To: <20201108221925.2344515-2-philmd@redhat.com>

On 08/11/2020 23.19, Philippe Mathieu-Daudé wrote:
> This cache rule is meant for Avocado artifacts, but affects
> all jobs. Moreover the 'acceptance_template' template already
> include a more detailled rule to cache artifacts.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  .gitlab-ci.yml | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 3b15ae5c302..5763318d375 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -7,12 +7,6 @@ stages:
>    - build
>    - test
>  
> -# We assume GitLab has it's own caching set up for RPM/APT repositories so we
> -# just take care of avocado assets here.
> -cache:
> -  paths:
> -    - $HOME/avocado/data/cache

Right, IIRC the path in $HOME wasn't working as expected anyway, that's why
we switched to a more complicated logic in the acceptance_template.

Reviewed-by: Thomas Huth <thuth@redhat.com>



  reply	other threads:[~2020-11-09  9:52 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-08 22:19 [PATCH v3 00/11] gitlab-ci: Allow forks to select & restrict build jobs Philippe Mathieu-Daudé
2020-11-08 22:19 ` [PATCH v3 01/11] gitlab-ci: Drop generic cache rule Philippe Mathieu-Daudé
2020-11-09  9:46   ` Thomas Huth [this message]
2020-11-08 22:19 ` [PATCH v3 02/11] gitlab-ci: Replace YAML anchors by extends (cross_system_build_job) Philippe Mathieu-Daudé
2020-11-10 20:21   ` Wainer dos Santos Moschetta
2020-11-08 22:19 ` [PATCH v3 03/11] gitlab-ci: Replace YAML anchors by extends (native_build_job) Philippe Mathieu-Daudé
2020-11-10 20:23   ` Wainer dos Santos Moschetta
2020-11-08 22:19 ` [PATCH v3 04/11] gitlab-ci: Replace YAML anchors by extends (native_test_job) Philippe Mathieu-Daudé
2020-11-10 20:24   ` Wainer dos Santos Moschetta
2020-11-08 22:19 ` [PATCH v3 05/11] gitlab-ci: Replace YAML anchors by extends (acceptance_test_job) Philippe Mathieu-Daudé
2020-11-10 20:35   ` Wainer dos Santos Moschetta
2020-11-08 22:19 ` [PATCH v3 06/11] gitlab-ci: Rename acceptance_test_job -> integration_test_job Philippe Mathieu-Daudé
2020-11-10 20:42   ` Wainer dos Santos Moschetta
2020-11-12  7:02     ` Thomas Huth
2020-11-12 20:31       ` Wainer dos Santos Moschetta
2020-11-16 12:56         ` Philippe Mathieu-Daudé
2020-11-23 15:36   ` Willian Rampazzo
2020-11-08 22:19 ` [PATCH v3 07/11] gitlab-ci: Extract common job definition as 'cross_common_job' Philippe Mathieu-Daudé
2020-11-09  9:52   ` Thomas Huth
2020-11-10 10:23     ` Philippe Mathieu-Daudé
2020-11-10 20:43   ` Wainer dos Santos Moschetta
2020-11-08 22:19 ` [PATCH v3 08/11] gitlab-ci: Extract common job definition as 'native_common_job' Philippe Mathieu-Daudé
2020-11-10 20:54   ` Wainer dos Santos Moschetta
2020-11-08 22:19 ` [PATCH v3 09/11] gitlab-ci: Add rules to select cross-jobs to build Philippe Mathieu-Daudé
2020-11-09  9:57   ` Thomas Huth
2020-11-08 22:19 ` [PATCH v3 10/11] gitlab-ci: Add rules to select building/testing native jobs Philippe Mathieu-Daudé
2020-11-08 22:19 ` [PATCH v3 11/11] gitlab-ci: Move artifacts expiry rule to common 'native_build_job' Philippe Mathieu-Daudé
2020-11-09  9:59   ` Thomas Huth
2020-11-16 13:01     ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd24518d-0ffa-8951-159a-3d0d810d06db@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=crosa@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).