From: Eric Blake <eblake@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 5/5] ps2: enable multimedia keys
Date: Wed, 26 Jul 2017 07:26:22 -0500 [thread overview]
Message-ID: <bd265d40-30e1-9ce1-bf14-e4e6f0ece24c@redhat.com> (raw)
In-Reply-To: <20170726115637.21558-6-kraxel@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 579 bytes --]
On 07/26/2017 06:56 AM, Gerd Hoffmann wrote:
> Fixes: 8c10e0baf0260b59a4e984744462a18016662e3e
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> hw/input/ps2.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/hw/input/ps2.c b/hw/input/ps2.c
Code fix by deletion is always fun (but is it really by deletion, if all
you are removing is the '#if 0' to re-enable code?)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2017-07-26 12:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 11:56 [Qemu-devel] [PATCH 0/5] ui: keymap fixes for 2.10 Gerd Hoffmann
2017-07-26 11:56 ` [Qemu-devel] [PATCH 1/5] ui: add next and prior keysyms Gerd Hoffmann
2017-07-26 12:00 ` Eric Blake
2017-07-26 11:56 ` [Qemu-devel] [PATCH 2/5] ui: move qemu_input_linux_to_qcode() Gerd Hoffmann
2017-07-26 12:14 ` Eric Blake
2017-07-26 11:56 ` [Qemu-devel] [PATCH 3/5] ui: update keymaps Gerd Hoffmann
2017-07-26 12:25 ` Eric Blake
2017-07-26 11:56 ` [Qemu-devel] [PATCH 4/5] ui: add multimedia keys Gerd Hoffmann
2017-07-26 12:02 ` Eric Blake
2017-07-26 12:08 ` Daniel P. Berrange
2017-07-26 12:12 ` Eric Blake
2017-07-26 12:38 ` Gerd Hoffmann
2017-07-26 12:24 ` Eric Blake
2017-07-26 12:39 ` Gerd Hoffmann
2017-07-26 11:56 ` [Qemu-devel] [PATCH 5/5] ps2: enable " Gerd Hoffmann
2017-07-26 12:26 ` Eric Blake [this message]
2017-07-26 12:09 ` [Qemu-devel] [PATCH 0/5] ui: keymap fixes for 2.10 no-reply
2017-07-26 12:22 ` Eric Blake
2017-07-26 12:49 ` Gerd Hoffmann
2017-07-26 13:06 ` Eric Blake
2017-08-08 9:20 ` Markus Armbruster
2017-08-08 15:04 ` Eric Blake
2017-08-14 6:56 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd265d40-30e1-9ce1-bf14-e4e6f0ece24c@redhat.com \
--to=eblake@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).