qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: fam@euphon.net, berrange@redhat.com, f4bug@amsat.org,
	aurelien@aurel32.net, pbonzini@redhat.com, stefanha@redhat.com,
	crosa@redhat.com
Subject: Re: [PATCH v3 05/13] docs/devel: make language a little less code centric
Date: Fri, 18 Nov 2022 08:52:49 +0100	[thread overview]
Message-ID: <bd283273-a07f-99f1-e1a3-1cf33a734824@linaro.org> (raw)
In-Reply-To: <20221117172532.538149-6-alex.bennee@linaro.org>

On 17/11/22 18:25, Alex Bennée wrote:
> We welcome all sorts of patches.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> Message-Id: <20221111145529.4020801-7-alex.bennee@linaro.org>
> ---
>   docs/devel/submitting-a-patch.rst | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/docs/devel/submitting-a-patch.rst b/docs/devel/submitting-a-patch.rst
> index fec33ce148..9c7c4331f3 100644
> --- a/docs/devel/submitting-a-patch.rst
> +++ b/docs/devel/submitting-a-patch.rst
> @@ -3,11 +3,11 @@
>   Submitting a Patch
>   ==================
>   
> -QEMU welcomes contributions of code (either fixing bugs or adding new
> -functionality). However, we get a lot of patches, and so we have some
> -guidelines about submitting patches. If you follow these, you'll help
> -make our task of code review easier and your patch is likely to be
> -committed faster.
> +QEMU welcomes contributions to fix bugs, add functionality or improve
> +the documentation. However, we get a lot of patches, and so we have
> +some guidelines about submitting them. If you follow these, you'll
> +help make our task of code review easier and your patch is likely to
> +be committed faster.

Less code centric:

"... you'll help make our task of contribution review easier and your 
change is likely to be accepted and committed faster."

Anyhow,
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



  reply	other threads:[~2022-11-18  7:53 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-17 17:25 [PATCH for 7.2 v3 00/13] testing and doc updates (pre-PR) Alex Bennée
2022-11-17 17:25 ` [PATCH v3 01/13] Run docker probe only if docker or podman are available Alex Bennée
2022-11-17 17:25 ` [PATCH v3 02/13] tests/avocado/machine_aspeed.py: Reduce noise on the console for SDK tests Alex Bennée
2022-11-17 17:25 ` [PATCH v3 03/13] tests/docker: allow user to override check target Alex Bennée
2022-11-17 17:25 ` [PATCH v3 04/13] docs/devel: add a maintainers section to development process Alex Bennée
2022-11-18  7:49   ` Philippe Mathieu-Daudé
2022-11-22  9:45     ` Alex Bennée
2022-11-17 17:25 ` [PATCH v3 05/13] docs/devel: make language a little less code centric Alex Bennée
2022-11-18  7:52   ` Philippe Mathieu-Daudé [this message]
2022-11-17 17:25 ` [PATCH v3 06/13] docs/devel: simplify the minimal checklist Alex Bennée
2022-11-18  7:55   ` Philippe Mathieu-Daudé
2023-07-05 11:44   ` Philippe Mathieu-Daudé
2023-08-25  7:25     ` Philippe Mathieu-Daudé
2023-09-01 10:08       ` Alex Bennée
2023-09-01 10:23         ` Daniel P. Berrangé
2022-11-17 17:25 ` [PATCH v3 07/13] docs/devel: try and improve the language around patch review Alex Bennée
2022-11-18  7:57   ` Philippe Mathieu-Daudé
2022-11-17 17:25 ` [PATCH v3 08/13] tests/avocado: Raise timeout for boot_linux.py:BootLinuxPPC64.test_pseries_tcg Alex Bennée
2022-11-17 17:25 ` [PATCH v3 09/13] tests/avocado: introduce alpine virt test for CI Alex Bennée
2022-11-18  8:04   ` Philippe Mathieu-Daudé
2022-11-17 17:25 ` [PATCH v3 10/13] tests/avocado: skip aarch64 cloud TCG tests in CI Alex Bennée
2022-11-18  8:05   ` Philippe Mathieu-Daudé
2022-11-17 17:25 ` [PATCH v3 11/13] gitlab: integrate coverage report Alex Bennée
2022-11-17 17:25 ` [PATCH v3 12/13] tests/avocado/boot_linux.py: Bump aarch64 virt test timeout to 720s Alex Bennée
2022-11-18  8:07   ` Philippe Mathieu-Daudé
2022-11-21 21:25   ` Peter Maydell
2022-11-17 17:25 ` [PATCH v3 13/13] ci: replace x86_64 macos-11 with aarch64 macos-12 Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd283273-a07f-99f1-e1a3-1cf33a734824@linaro.org \
    --to=philmd@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=berrange@redhat.com \
    --cc=crosa@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=fam@euphon.net \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).