Re: [PATCH v5 0/9] tests/functional: Adapt reverse_debugging to run w/o Avocado

[Thomas Huth <thuth@redhat.com>]

On 06/10/2025 11.58, Alex Bennée wrote:
> Thomas Huth <thuth@redhat.com> writes:
> 
>>   Hi Gustavo!
>>
>> On 03/10/2025 17.07, Gustavo Romero wrote:
>>> Hi Thomas,
>>> On 10/3/25 11:38, Gustavo Romero wrote:
>>>> Hi Thomas,
>>>>
>>>> On 10/3/25 10:30, Gustavo Romero wrote:
>>>>> Hi Thomas,
>>>>>
>>>>> On 10/2/25 14:52, Thomas Huth wrote:
>>>>>> On 02/10/2025 18.53, Thomas Huth wrote:
>>>>>>> On 02/10/2025 04.04, Gustavo Romero wrote:
>>>>>>>> The goal of this series is to remove Avocado as a dependency for running
>>>>>>>> the reverse_debugging functional test.
>>>>>>>>
>>>>>>>> After several rounds of discussions about v1 and v2, and experiments
>>>>>>>> done by Daniel and Thomas (thanks for all the experiments and comments
>>>>>>>> so far), I've taken a new approach and moved away from using a runner
>>>>>>>> for GDB. The changes, I believe, are much simpler now.
>>>>>>>
>>>>>>>    Hi Gustavo,
>>>>>>>
>>>>>>> unfortunately, this still seems to be broken on Fedora. After
>>>>>>> applying your series, I get:
>>>>>>>
>>>>>>> stderr:
>>>>>>> Traceback (most recent call last):
>>>>>>>     File
>>>>>>> "/home/thuth/devel/qemu/tests/functional/reverse_debugging.py",
>>>>>>> line 100, in reverse_debugging
>>>>>>>       self.reverse_debugging_run(vm, port, gdb_arch, last_icount)
>>>>>>>       ~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>>>>>>>     File "/usr/lib64/python3.13/unittest/case.py", line 156, in
>>>>>>> skip_wrapper
>>>>>>>       raise SkipTest(reason)
>>>>>>> unittest.case.SkipTest: Missing env var(s): QEMU_TEST_GDB
>>>>>>
>>>>>> Looks like it's required to explicitly use the --gdb=...
>>>>>> parameter of configure to make it work, and it does not work
>>>>>> without that paramter? Could you please have a look whether it
>>>>>> works without --gdb with the auto-detected gdb for you?
>> ...
>>> I've just tried it on Fedora 42 and GDB is correctly detected:
>>> $ ../configure --target-list=aarch64-softmmu --disable-docs
>>> $ make -j check-functional-aarch64
>>
>> I just tried it again, and it just seems to be broken in my build
>> folder where I do incremental builds. It works when I build QEMU in a
>> new folder from scratch - quite weird.
>>
>>> I have installed:
>>> gromero@gromero13:~/git/qemu/build$ dnf info gdb
>>> Updating and loading repositories:
>>> Repositories loaded.
>>> Installed packages
>>> Name            : gdb
>>> Epoch           : 0
>>> Version         : 16.3
>>> Release         : 1.fc42
>>> Architecture    : x86_64
>>> Installed size  : 455.3 KiB
>>> Source          : gdb-16.3-1.fc42.src.rpm
>>
>> I've got the very same package installed here.
>>
>>>> Are you sure GDB is installed in your test env?
>>>>
>>>> Do mind checking if:
>>>>
>>>> gromero@gromero0:/mnt/git/qemu_$ gdb_bin=$(command -v
>>>> "gdb-multiarch" || command -v "gdb")
>>>> gromero@gromero0:/mnt/git/qemu_$ echo $gdb_bin
>>>> /usr/bin/gdb
>>>>
>>>> works in your env and if QEMU_TEST_GDB is in:
>>>>
>>>> $ ./pyvenv/bin/meson test  --verbose --no-rebuild -t 1 --setup
>>>> thorough  --suite func-thorough  func-aarch64-reverse_debug
>>>>
>>>> output?
>>
>> $ echo $gdb_bin
>> /usr/bin/gdb
>>
>>   Thomas
> 
> Do you want me to drop the series until we figure out whats going on?

No, I think it's ok. There is no error anymore with v6, the test just got 
skipped. Since the test is normally skipped due to the FLAKY marker anyway, 
I think that's fine.
I can keep an eye on it and try to come up with a fix in case I can figure 
it out, but otherwise, I guess time will simply fix the problem when I 
occasionally blow away my build directory anyway due to other reasons.
So please go ahead and pick up v6.

  Thanks,
   Thomas