* [PATCH] hw/core/null-machine: Do not initialize unused chardev backends
@ 2020-06-24 10:56 Philippe Mathieu-Daudé
2020-06-24 11:01 ` Thomas Huth
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-06-24 10:56 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, Thomas Huth, Eduardo Habkost,
Philippe Mathieu-Daudé, Gerd Hoffmann,
Marc-André Lureau, Paolo Bonzini
The MachineClass uses an inverted logic (inherited from the
PC machines [*]) to create the chardev backends for the default
devices (see commits 998bbd74b9d..aa40fc9c964 and ac33f8fad14).
As the none-machine doesn't have any hardware device, it is
pointless to initialize chardev backends. Fix by setting the
'no_defaults' bits in its MachineClass.
Suggested-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/core/null-machine.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/hw/core/null-machine.c b/hw/core/null-machine.c
index cb47d9d4f8..7e693523d7 100644
--- a/hw/core/null-machine.c
+++ b/hw/core/null-machine.c
@@ -50,6 +50,11 @@ static void machine_none_machine_init(MachineClass *mc)
mc->max_cpus = 1;
mc->default_ram_size = 0;
mc->default_ram_id = "ram";
+ mc->no_serial = 1;
+ mc->no_parallel = 1;
+ mc->no_floppy = 1;
+ mc->no_cdrom = 1;
+ mc->no_sdcard = 1;
}
DEFINE_MACHINE("none", machine_none_machine_init)
--
2.21.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] hw/core/null-machine: Do not initialize unused chardev backends
2020-06-24 10:56 [PATCH] hw/core/null-machine: Do not initialize unused chardev backends Philippe Mathieu-Daudé
@ 2020-06-24 11:01 ` Thomas Huth
2020-07-06 16:24 ` Laurent Vivier
2020-06-26 21:15 ` Richard Henderson
2020-06-29 15:34 ` Paolo Bonzini
2 siblings, 1 reply; 6+ messages in thread
From: Thomas Huth @ 2020-06-24 11:01 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Peter Maydell, Eduardo Habkost, QEMU Trivial, Gerd Hoffmann,
Marc-André Lureau, Paolo Bonzini
On 24/06/2020 12.56, Philippe Mathieu-Daudé wrote:
> The MachineClass uses an inverted logic (inherited from the
> PC machines [*]) to create the chardev backends for the default
> devices (see commits 998bbd74b9d..aa40fc9c964 and ac33f8fad14).
>
> As the none-machine doesn't have any hardware device, it is
> pointless to initialize chardev backends. Fix by setting the
> 'no_defaults' bits in its MachineClass.
>
> Suggested-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/core/null-machine.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/hw/core/null-machine.c b/hw/core/null-machine.c
> index cb47d9d4f8..7e693523d7 100644
> --- a/hw/core/null-machine.c
> +++ b/hw/core/null-machine.c
> @@ -50,6 +50,11 @@ static void machine_none_machine_init(MachineClass *mc)
> mc->max_cpus = 1;
> mc->default_ram_size = 0;
> mc->default_ram_id = "ram";
> + mc->no_serial = 1;
> + mc->no_parallel = 1;
> + mc->no_floppy = 1;
> + mc->no_cdrom = 1;
> + mc->no_sdcard = 1;
> }
>
> DEFINE_MACHINE("none", machine_none_machine_init)
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] hw/core/null-machine: Do not initialize unused chardev backends
2020-06-24 11:01 ` Thomas Huth
@ 2020-07-06 16:24 ` Laurent Vivier
2020-07-07 10:38 ` Laurent Vivier
0 siblings, 1 reply; 6+ messages in thread
From: Laurent Vivier @ 2020-07-06 16:24 UTC (permalink / raw)
To: Thomas Huth, Philippe Mathieu-Daudé, qemu-devel
Cc: Peter Maydell, Eduardo Habkost, QEMU Trivial, Gerd Hoffmann,
Paolo Bonzini, Marc-André Lureau
Le 24/06/2020 à 13:01, Thomas Huth a écrit :
> On 24/06/2020 12.56, Philippe Mathieu-Daudé wrote:
>> The MachineClass uses an inverted logic (inherited from the
>> PC machines [*]) to create the chardev backends for the default
>> devices (see commits 998bbd74b9d..aa40fc9c964 and ac33f8fad14).
>>
>> As the none-machine doesn't have any hardware device, it is
>> pointless to initialize chardev backends. Fix by setting the
>> 'no_defaults' bits in its MachineClass.
>>
>> Suggested-by: Thomas Huth <thuth@redhat.com>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> hw/core/null-machine.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/hw/core/null-machine.c b/hw/core/null-machine.c
>> index cb47d9d4f8..7e693523d7 100644
>> --- a/hw/core/null-machine.c
>> +++ b/hw/core/null-machine.c
>> @@ -50,6 +50,11 @@ static void machine_none_machine_init(MachineClass
>> *mc)
>> mc->max_cpus = 1;
>> mc->default_ram_size = 0;
>> mc->default_ram_id = "ram";
>> + mc->no_serial = 1;
>> + mc->no_parallel = 1;
>> + mc->no_floppy = 1;
>> + mc->no_cdrom = 1;
>> + mc->no_sdcard = 1;
>> }
>> DEFINE_MACHINE("none", machine_none_machine_init)
>>
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
>
Applied to my trivial-patches-for-5.1 branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] hw/core/null-machine: Do not initialize unused chardev backends
2020-07-06 16:24 ` Laurent Vivier
@ 2020-07-07 10:38 ` Laurent Vivier
0 siblings, 0 replies; 6+ messages in thread
From: Laurent Vivier @ 2020-07-07 10:38 UTC (permalink / raw)
To: Thomas Huth, Philippe Mathieu-Daudé, qemu-devel
Cc: Peter Maydell, Eduardo Habkost, QEMU Trivial, Gerd Hoffmann,
Marc-André Lureau, Paolo Bonzini
Le 06/07/2020 à 18:24, Laurent Vivier a écrit :
> Le 24/06/2020 à 13:01, Thomas Huth a écrit :
>> On 24/06/2020 12.56, Philippe Mathieu-Daudé wrote:
>>> The MachineClass uses an inverted logic (inherited from the
>>> PC machines [*]) to create the chardev backends for the default
>>> devices (see commits 998bbd74b9d..aa40fc9c964 and ac33f8fad14).
>>>
>>> As the none-machine doesn't have any hardware device, it is
>>> pointless to initialize chardev backends. Fix by setting the
>>> 'no_defaults' bits in its MachineClass.
>>>
>>> Suggested-by: Thomas Huth <thuth@redhat.com>
>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>> ---
>>> hw/core/null-machine.c | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/hw/core/null-machine.c b/hw/core/null-machine.c
>>> index cb47d9d4f8..7e693523d7 100644
>>> --- a/hw/core/null-machine.c
>>> +++ b/hw/core/null-machine.c
>>> @@ -50,6 +50,11 @@ static void machine_none_machine_init(MachineClass
>>> *mc)
>>> mc->max_cpus = 1;
>>> mc->default_ram_size = 0;
>>> mc->default_ram_id = "ram";
>>> + mc->no_serial = 1;
>>> + mc->no_parallel = 1;
>>> + mc->no_floppy = 1;
>>> + mc->no_cdrom = 1;
>>> + mc->no_sdcard = 1;
>>> }
>>> DEFINE_MACHINE("none", machine_none_machine_init)
>>>
>>
>> Reviewed-by: Thomas Huth <thuth@redhat.com>
>>
>>
>
> Applied to my trivial-patches-for-5.1 branch.
Removed as it is in Paolo's PR.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] hw/core/null-machine: Do not initialize unused chardev backends
2020-06-24 10:56 [PATCH] hw/core/null-machine: Do not initialize unused chardev backends Philippe Mathieu-Daudé
2020-06-24 11:01 ` Thomas Huth
@ 2020-06-26 21:15 ` Richard Henderson
2020-06-29 15:34 ` Paolo Bonzini
2 siblings, 0 replies; 6+ messages in thread
From: Richard Henderson @ 2020-06-26 21:15 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Peter Maydell, Thomas Huth, Eduardo Habkost, Gerd Hoffmann,
Marc-André Lureau, Paolo Bonzini
On 6/24/20 3:56 AM, Philippe Mathieu-Daudé wrote:
> The MachineClass uses an inverted logic (inherited from the
> PC machines [*]) to create the chardev backends for the default
> devices (see commits 998bbd74b9d..aa40fc9c964 and ac33f8fad14).
>
> As the none-machine doesn't have any hardware device, it is
> pointless to initialize chardev backends. Fix by setting the
> 'no_defaults' bits in its MachineClass.
>
> Suggested-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/core/null-machine.c | 5 +++++
> 1 file changed, 5 insertions(+)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] hw/core/null-machine: Do not initialize unused chardev backends
2020-06-24 10:56 [PATCH] hw/core/null-machine: Do not initialize unused chardev backends Philippe Mathieu-Daudé
2020-06-24 11:01 ` Thomas Huth
2020-06-26 21:15 ` Richard Henderson
@ 2020-06-29 15:34 ` Paolo Bonzini
2 siblings, 0 replies; 6+ messages in thread
From: Paolo Bonzini @ 2020-06-29 15:34 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Peter Maydell, Thomas Huth, Eduardo Habkost, Gerd Hoffmann,
Marc-André Lureau
On 24/06/20 12:56, Philippe Mathieu-Daudé wrote:
> The MachineClass uses an inverted logic (inherited from the
> PC machines [*]) to create the chardev backends for the default
> devices (see commits 998bbd74b9d..aa40fc9c964 and ac33f8fad14).
>
> As the none-machine doesn't have any hardware device, it is
> pointless to initialize chardev backends. Fix by setting the
> 'no_defaults' bits in its MachineClass.
>
> Suggested-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/core/null-machine.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/hw/core/null-machine.c b/hw/core/null-machine.c
> index cb47d9d4f8..7e693523d7 100644
> --- a/hw/core/null-machine.c
> +++ b/hw/core/null-machine.c
> @@ -50,6 +50,11 @@ static void machine_none_machine_init(MachineClass *mc)
> mc->max_cpus = 1;
> mc->default_ram_size = 0;
> mc->default_ram_id = "ram";
> + mc->no_serial = 1;
> + mc->no_parallel = 1;
> + mc->no_floppy = 1;
> + mc->no_cdrom = 1;
> + mc->no_sdcard = 1;
> }
>
> DEFINE_MACHINE("none", machine_none_machine_init)
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-07-07 10:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-24 10:56 [PATCH] hw/core/null-machine: Do not initialize unused chardev backends Philippe Mathieu-Daudé
2020-06-24 11:01 ` Thomas Huth
2020-07-06 16:24 ` Laurent Vivier
2020-07-07 10:38 ` Laurent Vivier
2020-06-26 21:15 ` Richard Henderson
2020-06-29 15:34 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).