From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: Rowan Hart <rowanbhart@gmail.com>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Alexandre Iooss" <erdnaxe@crans.org>,
"Mahmoud Mandour" <ma.mandourr@gmail.com>
Subject: Re: [PATCH] plugins: add plugin API to read guest memory
Date: Thu, 22 Aug 2024 13:37:47 -0700 [thread overview]
Message-ID: <bd4a4d18-1e4e-4f90-b9dc-7d0c4c2c3459@linaro.org> (raw)
In-Reply-To: <d134a954-0380-41dc-9e3b-75e1dc2e2bbf@linaro.org>
On 8/22/24 13:33, Pierrick Bouvier wrote:
>> + *
>> + * version 3:
>> + * - modified arguments and return value of qemu_plugin_insn_data to copy
>> + * the data into a user-provided buffer instead of returning a pointer
>> + * to the data.
>> + *
>
> Is it a change left on your side, or a bad diff?
>
Just saw it's a comment we forgot to add when bumping version. Thanks
for changing it.
next prev parent reply other threads:[~2024-08-22 20:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 23:56 [PATCH] plugins: add plugin API to read guest memory Rowan Hart
2024-08-22 20:33 ` Pierrick Bouvier
2024-08-22 20:37 ` Pierrick Bouvier [this message]
2024-08-23 10:29 ` Alex Bennée
2024-08-26 18:54 ` Rowan Hart
2024-08-26 18:47 ` Rowan Hart
2024-08-26 19:11 ` Pierrick Bouvier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd4a4d18-1e4e-4f90-b9dc-7d0c4c2c3459@linaro.org \
--to=pierrick.bouvier@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=erdnaxe@crans.org \
--cc=ma.mandourr@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=rowanbhart@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).